feat: ability to disable extract async modules, lint fix

Author: lsycxyj

src/index.js

@@ -152,6 +152,7 @@ class MiniCssExtractPlugin {
   apply(compiler) {
     compiler.hooks.thisCompilation.tap(pluginName, (compilation) => {
       const asyncModuleToBeRebuild = new Set();
+      // eslint-disable-next-line no-param-reassign
       compilation[MODULE_TYPE] = {
         asyncModuleToBeRebuild,
       };
@@ -450,42 +451,40 @@ class MiniCssExtractPlugin {
       );
 
       const len = `// extracted by ${pluginName}`.length;
-      mainTemplate.hooks.beforeStartup.tap(
-        pluginName,
-        (source, chunk, hash) => {
-          for (const _m of asyncModuleToBeRebuild) {
-            const issuerDeps = _m.issuer.dependencies;
-            let firstIndex = -1;
-            const content = [];
-
-            for (let i = issuerDeps.length - 1; i >= 0; i--) {
-              const {module} = issuerDeps[i];
-              if (asyncModuleToBeRebuild.has(module)) {
-                firstIndex = i;
-                content.push(module.content.replace(/(?:[\r\n]+)/g, '\\n'));
-                issuerDeps.splice(i, 1);
-              }
+      mainTemplate.hooks.beforeStartup.tap(pluginName, (source) => {
+        for (const moduleToBeRebuild of asyncModuleToBeRebuild) {
+          const issuerDeps = moduleToBeRebuild.issuer.dependencies;
+          let firstIndex = -1;
+          const content = [];
+
+          for (let i = issuerDeps.length - 1; i >= 0; i--) {
+            const { module } = issuerDeps[i];
+            if (asyncModuleToBeRebuild.has(module)) {
+              firstIndex = i;
+              content.push(module.content.replace(/(?:[\r\n]+)/g, '\\n'));
+              issuerDeps.splice(i, 1);
             }
+          }
 
-            if (firstIndex > -1) {
-              issuerDeps.splice(
-                firstIndex,
+          if (firstIndex > -1) {
+            issuerDeps.splice(
+              firstIndex,
+              0,
+              new ReplaceDependency(`module.exports = "${content.join('')}";`, [
                 0,
-                new ReplaceDependency(
-                  `module.exports = "${content.join('')}";`,
-                  [0, len]
-                )
-              );
-            }
+                len,
+              ])
+            );
           }
-          return source;
         }
-      );
+
+        return source;
+      });
     });
   }
 
   shouldDisableAsync({ module }) {
-    const {disableAsync} = this.options;
+    const { disableAsync } = this.options;
     let shouldDisable = false;
     if (disableAsync === true) {
       shouldDisable = true;

src/lib/ReplaceDependency.js

@@ -2,6 +2,7 @@ const NullDependency = require('webpack/lib/dependencies/NullDependency');
 
 class ReplaceDependency extends NullDependency {
   constructor(replacement, range) {
+    /* eslint-disable class-methods-use-this */
     super();
     this.replacement = replacement;
     this.range = range;

test/cases/disable-async-bool/async.js

@@ -3,4 +3,4 @@ import './in-async.css';
 import './in-async2.css';
 import './both-async.css';
 
-console.log('async.js');
+// console.log('async.js');

test/cases/disable-async-bool/in-async.js

@@ -1 +1 @@
-console.log('in-async.js');
+// console.log('in-async.js');

test/cases/disable-async-bool/index.js

@@ -5,4 +5,4 @@ import('./async');
 
 import('./async.css');
 
-console.log('index.js');
+// console.log('index.js');

test/cases/disable-async-func/async.js

@@ -6,4 +6,4 @@ import './both-async.css';
 import './both-page-async-disabled.css';
 import './both-page-async.css';
 
-console.log('async.js');
+// console.log('async.js');

test/cases/disable-async-func/async2.js

@@ -1,4 +1,4 @@
 import './both-page-async-disabled.css';
 import './both-page-async.css';
 
-console.log('async2.js');
+// console.log('async2.js');

test/cases/disable-async-func/in-async.js

@@ -1 +1 @@
-console.log('in-async.js');
+// console.log('in-async.js');

test/cases/disable-async-func/index.js

@@ -5,4 +5,4 @@ import('./async');
 
 import('./async.css');
 
-console.log('index.js');
+// console.log('index.js');

test/cases/disable-async-func/index2.js

@@ -1,3 +1,3 @@
 import('./async2');
 
-console.log('index2');
+// console.log('index2');