Skip to content

Commit 86938aa

Browse files
committed
chore: fix lint
1 parent 6913eef commit 86938aa

File tree

5 files changed

+17
-22
lines changed

5 files changed

+17
-22
lines changed

src/loader.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -458,12 +458,12 @@ function pitch(request) {
458458
(loaderContext, module) => {
459459
if (module.request === request) {
460460
// eslint-disable-next-line no-param-reassign
461-
module.loaders = loaders.map((loader) => {
461+
module.loaders = loaders.map((loaderItem) => {
462462
return {
463463
type: null,
464-
loader: loader.path,
465-
options: loader.options,
466-
ident: loader.ident,
464+
loader: loaderItem.path,
465+
options: loaderItem.options,
466+
ident: loaderItem.ident,
467467
};
468468
});
469469
}

src/utils.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,11 @@ const quoteMeta = (str) => str.replace(/[-[\]\\/{}()*+?.^$|]/g, "\\$&");
236236
* @returns {string} common prefix
237237
*/
238238
const getCommonPrefix = (items) => {
239-
let prefix = items[0];
239+
const [firstItem, ...restItems] = items;
240+
let prefix = firstItem;
240241

241-
for (let i = 1; i < items.length; i++) {
242-
const item = items[i];
242+
for (let i = 0; i < restItems.length; i++) {
243+
const item = restItems[i];
243244
for (let p = 0; p < prefix.length; p++) {
244245
if (item[p] !== prefix[p]) {
245246
prefix = prefix.slice(0, p);
@@ -256,10 +257,11 @@ const getCommonPrefix = (items) => {
256257
* @returns {string} common suffix
257258
*/
258259
const getCommonSuffix = (items) => {
259-
let suffix = items[0];
260+
const [firstItem, ...restItems] = items;
261+
let suffix = firstItem;
260262

261-
for (let i = 1; i < items.length; i++) {
262-
const item = items[i];
263+
for (let i = 0; i < restItems.length; i++) {
264+
const item = restItems[i];
263265
for (let p = item.length - 1, s = suffix.length - 1; s >= 0; p--, s--) {
264266
if (item[p] !== suffix[s]) {
265267
suffix = suffix.slice(s + 1);
@@ -285,7 +287,7 @@ const popCommonItems = (itemsSet, getKey, condition) => {
285287
const key = getKey(item);
286288
if (key) {
287289
let list = map.get(key);
288-
if (list === undefined) {
290+
if (!list) {
289291
/** @type {Array<string>} */
290292
list = [];
291293
map.set(key, list);
@@ -358,7 +360,7 @@ const itemsToRegexp = (itemsArr) => {
358360

359361
if (prefix.length > 0 || suffix.length > 0) {
360362
return `${quoteMeta(prefix)}${itemsToRegexp(
361-
itemsArr.map((i) => i.slice(prefix.length, -suffix.length || undefined))
363+
itemsArr.map((i) => i.slice(prefix.length, -suffix.length || 0))
362364
)}${quoteMeta(suffix)}`;
363365
}
364366
}

test/cases/new-url/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1+
// Test URL creation
12
const myURL = new URL("./style.css", import.meta.url);
2-
3-
console.log(myURL);
3+
export default myURL;

test/manual/src/worker.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
import "./worker.css";
22

33
// eslint-disable-next-line no-undef
4-
self.onmessage = (event) => {
5-
console.log(`Received message from application: ${event.data}`);
6-
4+
self.onmessage = () => {
75
// eslint-disable-next-line no-undef
86
self.postMessage("I'm alive!");
97
};

test/manual/webpack.config.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@ const ENABLE_ES_MODULE =
1414
const OLD_API =
1515
typeof process.env.OLD_API !== "undefined" ? yn(process.env.OLD_API) : false;
1616

17-
console.log("OPTIONS:");
18-
console.log("ENABLE_HMR:", ENABLE_HMR);
19-
console.log("ENABLE_ES_MODULE:", ENABLE_ES_MODULE);
20-
console.log("OLD_API:", OLD_API);
21-
2217
module.exports = {
2318
devtool: false,
2419
mode: "development",

0 commit comments

Comments
 (0)