Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit de9d1a5

Browse files
refactor: dropped webpack@4 (#33)
BREAKING CHANGE: minimum supported webpack version is `5`
1 parent c048eac commit de9d1a5

File tree

7 files changed

+59
-30
lines changed

7 files changed

+59
-30
lines changed

.github/workflows/nodejs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
matrix:
5757
os: [ubuntu-latest, windows-latest, macos-latest]
5858
node-version: [10.x, 12.x, 14.x]
59-
webpack-version: [4, latest]
59+
webpack-version: [latest]
6060

6161
runs-on: ${{ matrix.os }}
6262

package-lock.json

Lines changed: 29 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,10 @@
3838
"dist"
3939
],
4040
"peerDependencies": {
41-
"webpack": "^4.0.0 || ^5.0.0"
41+
"webpack": "^5.0.0"
4242
},
4343
"dependencies": {
44-
"loader-utils": "^2.0.0",
45-
"schema-utils": "^3.0.0"
44+
"loader-utils": "^2.0.0"
4645
},
4746
"devDependencies": {
4847
"@babel/cli": "^7.13.14",

src/index.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,12 @@
33
Author Tobias Koppers @sokra
44
*/
55

6-
import { getOptions, interpolateName } from "loader-utils";
7-
import { validate } from "schema-utils";
6+
import { interpolateName } from "loader-utils";
87

98
import schema from "./options.json";
109

1110
export default function loader(content) {
12-
const options = getOptions(this);
13-
14-
validate(schema, options, {
15-
name: "Node Loader",
16-
baseDataPath: "options",
17-
});
11+
const options = this.getOptions(schema);
1812

1913
const name = interpolateName(
2014
this,

src/options.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"title": "Node Loader options",
23
"type": "object",
34
"properties": {
45
"name": {

test/fixtures/example/package-lock.json

Lines changed: 23 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/helpers/getCompiler.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,7 @@ export default (fixture, loaderOptions = {}, config = {}) => {
3939
const compiler = webpack(fullConfig);
4040

4141
if (!config.outputFileSystem) {
42-
const outputFileSystem = createFsFromVolume(new Volume());
43-
// Todo remove when we drop webpack@4 support
44-
outputFileSystem.join = path.join.bind(path);
45-
46-
compiler.outputFileSystem = outputFileSystem;
42+
compiler.outputFileSystem = createFsFromVolume(new Volume());
4743
}
4844

4945
return compiler;

0 commit comments

Comments
 (0)