Skip to content

Commit 3a765d9

Browse files
refactor: update types
1 parent f5677bc commit 3a765d9

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

lib/ResolverFactory.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ const UseFilePlugin = require("./UseFilePlugin");
5050
/** @typedef {string|string[]|false} AliasOptionNewRequest */
5151
/** @typedef {{[k: string]: AliasOptionNewRequest}} AliasOptions */
5252
/** @typedef {{[k: string]: string|string[] }} ExtensionAliasOptions */
53-
/** @typedef {{apply: function(Resolver): void} | function(this: Resolver, Resolver): void} Plugin */
53+
/** @typedef {false | 0 | "" | null | undefined} Falsy */
54+
/** @typedef {{apply: function(Resolver): void} | (function(this: Resolver, Resolver): void) | Falsy} Plugin */
5455

5556
/**
5657
* @typedef {Object} UserResolveOptions

test/plugins.test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ describe("plugins", function () {
4444
const resolver = ResolverFactory.createResolver({
4545
fileSystem: require("fs"),
4646
plugins: [
47+
0,
48+
"",
4749
false,
4850
null,
4951
undefined,

types.d.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,11 @@ declare interface ParsedIdentifier {
281281
internal: boolean;
282282
}
283283
type Plugin =
284+
| undefined
285+
| null
286+
| false
287+
| ""
288+
| 0
284289
| { apply: (arg0: Resolver) => void }
285290
| ((this: Resolver, arg1: Resolver) => void);
286291
declare interface PnpApiImpl {

0 commit comments

Comments
 (0)