Merge pull request #333 from webpack/fix/absolute-path-alias

fix absolute path alias

Author: sokra

lib/AliasPlugin.js

@@ -41,7 +41,12 @@ module.exports = class AliasPlugin {
 						let shouldStop = false;
 						if (
 							innerRequest === item.name ||
-							(!item.onlyModule && innerRequest.startsWith(item.name + "/"))
+							(!item.onlyModule &&
+								innerRequest.startsWith(
+									request.request
+										? `${item.name}/`
+										: resolver.join(item.name, "_").slice(0, -1)
+								))
 						) {
 							const remainingRequest = innerRequest.substr(item.name.length);
 							const resolveWithAlias = (alias, callback) => {

test/alias.js

@@ -1,7 +1,12 @@
-require("should");
+const should = require("should");
 
-var { Volume } = require("memfs");
-var { ResolverFactory } = require("../");
+const path = require("path");
+const { Volume } = require("memfs");
+const { ResolverFactory } = require("../");
+const CachedInputFileSystem = require("../lib/CachedInputFileSystem");
+const fs = require("fs");
+
+const nodeFileSystem = new CachedInputFileSystem(fs, 4000);
 
 describe("alias", function () {
 	var resolver;
@@ -144,4 +149,20 @@ describe("alias", function () {
 			}
 		);
 	});
+
+	it("should work with absolute paths", done => {
+		const resolver = ResolverFactory.createResolver({
+			alias: {
+				[path.resolve(__dirname, "fixtures", "foo")]: false
+			},
+			modules: path.resolve(__dirname, "fixtures"),
+			fileSystem: nodeFileSystem
+		});
+
+		resolver.resolve({}, __dirname, "foo/index", {}, (err, result) => {
+			if (err) done(err);
+			should(result).be.eql(false);
+			done();
+		});
+	});
 });

test/fixtures/foo/index.js

@@ -0,0 +1,4 @@
+{
+  "name": "foo",
+  "version": "1.0.0"
+}