style: fix lint errors in rules

Author: joshwiens

package.json

@@ -8,15 +8,16 @@
     "rules"
   ],
   "scripts": {
-    "prelint": "editorconfig-tools check * rules/* test/*",
-    "lint": "eslint .",
+    "config": "editorconfig-tools check * rules/* test/*",
+    "lint": "eslint rules/* test/*",
     "release": "standard-version"
   },
   "dependencies": {},
   "devDependencies": {
     "editorconfig-tools": "^0.1.1",
     "eslint": "^3.13.0",
     "eslint-find-rules": "^1.14.3",
+    "eslint-plugin-import": "^2.2.0",
     "standard-version": "^4.0.0"
   },
   "peerDependencies": {

rules/best-practices.js

@@ -27,7 +27,7 @@ module.exports = {
     'consistent-return': 'error',
 
     // enforce consistent brace style for all control statements
-    // http://eslint.org/docs/rules/curly
+    // http://eslint.org/docs/rules/curly
     curly: ['error', 'multi-line'],
 
     // require default cases in switch statements
@@ -77,7 +77,7 @@ module.exports = {
         'arrowFunctions',
         'functions',
         'methods',
-      ]
+      ],
     }],
 
     // disallow empty destructuring patterns
@@ -313,6 +313,6 @@ module.exports = {
 
     // require or disallow “Yoda” conditions
     // http://eslint.org/docs/rules/yoda
-    yoda: 'error'
-  }
+    yoda: 'error',
+  },
 };

rules/es2015.js

@@ -1,14 +1,14 @@
 module.exports = {
   env: {
-    es6: true
+    es6: true,
   },
   parserOptions: {
     ecmaVersion: 6,
     sourceType: 'module',
     ecmaFeatures: {
       generators: false,
-      objectLiteralDuplicateProperties: false
-    }
+      objectLiteralDuplicateProperties: false,
+    },
   },
 
   rules: {
@@ -28,7 +28,7 @@ module.exports = {
     // http://eslint.org/docs/rules/arrow-spacing
     'arrow-spacing': ['error', {
       before: true,
-      after: true
+      after: true,
     }],
 
     // require super() calls in constructors
@@ -39,7 +39,7 @@ module.exports = {
     // http://eslint.org/docs/rules/generator-star-spacing
     'generator-star-spacing': ['error', {
       before: false,
-      after: true
+      after: true,
     }],
 
     // disallow reassigning class members
@@ -168,6 +168,6 @@ module.exports = {
 
     // require or disallow spacing around the * in yield* expressions
     // http://eslint.org/docs/rules/yield-star-spacing
-    'yield-star-spacing': ['error', 'after']
-  }
+    'yield-star-spacing': ['error', 'after'],
+  },
 };

rules/imports.js

@@ -1,20 +1,20 @@
 module.exports = {
   env: {
-    es6: true
+    es6: true,
   },
   parserOptions: {
     ecmaVersion: 6,
-    sourceType: 'module'
+    sourceType: 'module',
   },
   plugins: [
-    'import'
+    'import',
   ],
 
   settings: {
     'import/resolver': {
       node: {
-        extensions: ['.js', '.json']
-      }
+        extensions: ['.js', '.json'],
+      },
     },
     'import/extensions': [
       '.js',
@@ -69,19 +69,32 @@ module.exports = {
     // paths are treated both as absolute paths, and relative to process.cwd()
     'import/no-extraneous-dependencies': ['error', {
       devDependencies: [
-        'test/**', // tape, common npm pattern
-        'tests/**', // also common npm pattern
-        'spec/**', // mocha, rspec-like pattern
-        '**/__tests__/**', // jest pattern
-        'test.js', // repos with a single test file
-        'test-*.js', // repos with multiple top-level test files
-        '**/*.test.js', // tests where the extension denotes that it is a test
-        '**/webpack.config.js', // webpack config
-        '**/webpack.config.*.js', // webpack config
-        '**/rollup.config.js', // rollup config
-        '**/gulpfile.js', // gulp config
-        '**/gulpfile.*.js', // gulp config
-        '**/Gruntfile', // grunt config
+        // tape, common npm pattern
+        'test/**',
+        // also common npm pattern
+        'tests/**',
+        // mocha, rspec-like pattern
+        'spec/**',
+        // jest pattern
+        '**/__tests__/**',
+        // repos with a single test file
+        'test.js',
+        // repos with multiple top-level test files
+        'test-*.js',
+        // tests where the extension denotes that it is a test
+        '**/*.test.js',
+        // webpack config
+        '**/webpack.config.js',
+        // webpack config
+        '**/webpack.config.*.js',
+        // rollup config
+        '**/rollup.config.js',
+        // gulp config
+        '**/gulpfile.js',
+        // gulp config
+        '**/gulpfile.*.js',
+        // grunt config
+        '**/Gruntfile',
       ],
       optionalDependencies: false,
     }],

rules/node.js

@@ -2,7 +2,7 @@ module.exports = {
   env: {
     node: true,
     jest: true,
-    mocha: true
+    mocha: true,
   },
 
   rules: {
@@ -45,5 +45,5 @@ module.exports = {
     // disallow synchronous methods
     // http://eslint.org/docs/rules/no-sync
     'no-sync': 'off',
-  }
+  },
 };

rules/possible-errors.js

@@ -127,5 +127,5 @@ module.exports = {
     // enforce comparing typeof expressions against valid strings
     // http://eslint.org/docs/rules/valid-typeof
     'valid-typeof': ['error', { requireStringLiterals: true }],
-  }
+  },
 };

rules/stylistic-issues.js

@@ -68,7 +68,7 @@ module.exports = {
     // require function names to match the name of the variable or property to which they are assigned
     // http://eslint.org/docs/rules/func-name-matching
     'func-name-matching': ['off', 'always', {
-      includeCommonJSModuleExports: false
+      includeCommonJSModuleExports: false,
     }],
 
     // require or disallow named function expressions
@@ -99,12 +99,12 @@ module.exports = {
       outerIIFEBody: 1,
       FunctionDeclaration: {
         parameters: 1,
-        body: 1
+        body: 1,
       },
       FunctionExpression: {
         parameters: 1,
-        body: 1
-      }
+        body: 1,
+      },
     }],
 
     // enforce the consistent use of either double or single quotes in JSX attributes
@@ -123,8 +123,8 @@ module.exports = {
       overrides: {
         return: { after: true },
         throw: { after: true },
-        case: { after: true }
-      }
+        case: { after: true },
+      },
     }],
 
     // enforce position of line comments
@@ -169,7 +169,7 @@ module.exports = {
     'max-lines': ['off', {
       max: 300,
       skipBlankLines: true,
-      skipComments: true
+      skipComments: true,
     }],
 
     // enforce a maximum depth that callbacks can be nested
@@ -245,9 +245,9 @@ module.exports = {
         ['&', '|', '^', '~', '<<', '>>', '>>>'],
         ['==', '!=', '===', '!==', '>', '>=', '<', '<='],
         ['&&', '||'],
-        ['in', 'instanceof']
+        ['in', 'instanceof'],
       ],
-      allowSamePrecedence: false
+      allowSamePrecedence: false,
     }],
 
     // disallow mixed spaces and tabs for indentation
@@ -314,7 +314,7 @@ module.exports = {
     // http://eslint.org/docs/rules/object-curly-newline
     'object-curly-newline': ['off', {
       ObjectExpression: { minProperties: 0, multiline: true },
-      ObjectPattern: { minProperties: 0, multiline: true }
+      ObjectPattern: { minProperties: 0, multiline: true },
     }],
 
     // require padding inside curly braces
@@ -384,7 +384,7 @@ module.exports = {
     'space-before-function-paren': ['error', {
       anonymous: 'always',
       named: 'never',
-      asyncArrow: 'always'
+      asyncArrow: 'always',
     }],
 
     // enforce consistent spacing inside parentheses
@@ -415,7 +415,7 @@ module.exports = {
         exceptions: ['-', '+'],
         markers: ['=', '!'],
         balanced: false,
-      }
+      },
     }],
 
     // require or disallow Unicode byte order mark (BOM)
@@ -424,6 +424,6 @@ module.exports = {
 
     // require parenthesis around regex literals
     // http://eslint.org/docs/rules/wrap-regex
-    'wrap-regex': 'off'
-  }
+    'wrap-regex': 'off',
+  },
 };