refactor: enable more rules (#32)

Author: alexander-akait

configs/browser.js

@@ -1,11 +1,18 @@
 import globals from "globals";
+import importPlugin from "eslint-plugin-import";
 
 const recommendedBrowserConfig = {
 	languageOptions: {
 		globals: {
 			...globals.browser,
 		},
 	},
+	plugins: {
+		import: importPlugin,
+	},
+	rules: {
+		"import/extensions": ["error", "always", { ignorePackages: true }],
+	},
 };
 
 export default {

configs/index.js

@@ -3,7 +3,7 @@ import javascriptConfig from "./javascript.js";
 import jestConfig from "./jest.js";
 import markdownConfig from "./markdown.js";
 import nodeConfig from "./node.js";
-import prettierConfig from "./prettier.js";
+import stylisticConfig from "./stylistic.js";
 import typescriptConfig from "./typescript.js";
 
 const configs = {
@@ -12,7 +12,7 @@ const configs = {
 	...jestConfig,
 	...markdownConfig,
 	...nodeConfig,
-	...prettierConfig,
+	...stylisticConfig,
 	...typescriptConfig,
 };
 

configs/javascript.js

@@ -228,7 +228,7 @@ const suggestions = {
 	// No need
 	// "consistent-this": "error",
 
-	// No need here
+	// Configuration in `stylistic`
 	// curly: "off",
 
 	// No need
@@ -336,7 +336,6 @@ const suggestions = {
 
 	"no-alert": "error",
 
-	// No need
 	"no-array-constructor": "error",
 
 	// No need
@@ -744,8 +743,7 @@ const unicornRules = {
 	// No need
 	// "unicorn/no-await-expression-member": "off",
 
-	// No need
-	// "unicorn/no-await-in-promise-methods": "off",
+	"unicorn/no-await-in-promise-methods": "error",
 
 	"unicorn/no-console-spaces": "error",
 
@@ -1093,7 +1091,7 @@ const importRules = {
 	// No need
 	// "import/exports-last": "off",
 
-	// TODO
+	// Not here
 	// "import/extensions": ["error", "always", { ignorePackages: true }],
 
 	"import/first": "error",
@@ -1105,7 +1103,7 @@ const importRules = {
 	// "import/max-dependencies": "off",
 
 	// No need
-	// TODO
+	// We have `@stylistic/padding-line-between-statements`
 	// "import/newline-after-import": "off",
 
 	// No need

configs/node.js

@@ -1,5 +1,6 @@
 import globals from "globals";
 import nodePlugin from "eslint-plugin-n";
+import importPlugin from "eslint-plugin-import";
 
 const commonRules = {
 	// No need
@@ -8,8 +9,8 @@ const commonRules = {
 	// Depends on `sourceType` and enabled below only for commonjs
 	// "n/exports-style": "error",
 
-	// Depends on `sourceType` and enabled below only for module
-	// "n/file-extension-in-import": "error",
+	// We have the `import/extensions` rule
+	"n/file-extension-in-import": "off",
 
 	// There is no need, as in some cases we want to load a module lazily.
 	// "n/global-require": "error",
@@ -118,26 +119,36 @@ const commonRules = {
 const commonjs = {
 	...nodePlugin.configs["flat/recommended-script"],
 	name: "node/commonjs",
+	plugins: {
+		...nodePlugin.configs["flat/recommended-script"].plugins,
+		import: importPlugin,
+	},
 	rules: {
 		...commonRules,
 		"n/exports-style": "error",
 		"n/no-path-concat": "error",
+		"import/extensions": ["error", "never", { ignorePackages: true }],
 	},
 };
 
 const module = {
 	...nodePlugin.configs["flat/recommended-module"],
 	name: "node/module",
+	plugins: {
+		...nodePlugin.configs["flat/recommended-script"].plugins,
+		import: importPlugin,
+	},
 	rules: {
 		...commonRules,
-		"n/file-extension-in-import": "error",
+		"import/extensions": ["error", "always", { ignorePackages: true }],
 	},
 };
 
 const dirty = {
 	name: "node/dirty",
 	plugins: {
 		n: nodePlugin,
+		import: importPlugin,
 	},
 	languageOptions: {
 		sourceType: "module",
@@ -156,6 +167,8 @@ const dirty = {
 	rules: {
 		...commonjs.rules,
 		...module.rules,
+		// Disable for dirty modules
+		"import/extensions": ["off"],
 	},
 };
 

configs/prettier.js

@@ -0,0 +1,77 @@
+import prettierPlugin from "eslint-plugin-prettier";
+import prettierConfig from "eslint-plugin-prettier/recommended";
+import stylisticPlugin from "@stylistic/eslint-plugin";
+
+const recommendedConfig = {
+	...prettierConfig,
+	name: "stylistic/recommended",
+	plugins: {
+		"@stylistic": stylisticPlugin,
+		prettier: prettierPlugin,
+	},
+	rules: {
+		"prettier/prettier": "error",
+		curly: ["error", "multi-line", "consistent"],
+		"@stylistic/lines-between-class-members": "error",
+		"@stylistic/quotes": [
+			"error",
+			"double",
+			{ avoidEscape: true, allowTemplateLiterals: false },
+		],
+		"@stylistic/spaced-comment": [
+			"error",
+			"always",
+			{
+				line: {
+					// Space here to support sprockets directives
+					markers: ["=", "!"],
+					exceptions: ["-", "+"],
+				},
+				block: {
+					// Space here to support sprockets directives
+					markers: ["=", "!"],
+					exceptions: ["-", "+"],
+					balanced: true,
+				},
+			},
+		],
+		"@stylistic/padding-line-between-statements": [
+			"error",
+			{ blankLine: "always", prev: ["cjs-export"], next: "*" },
+			{ blankLine: "always", prev: "*", next: ["cjs-export"] },
+			{
+				blankLine: "any",
+				prev: ["cjs-export"],
+				next: ["cjs-export"],
+			},
+			// Require newline between blocks of `cjs-import` and any lines between `cjs-import`
+			{ blankLine: "always", prev: ["cjs-import"], next: "*" },
+			{ blankLine: "always", prev: "*", next: ["cjs-import"] },
+			{
+				blankLine: "any",
+				prev: ["cjs-import"],
+				next: ["cjs-import"],
+			},
+			// Require newline between blocks of `export` and any lines between `export`
+			{ blankLine: "always", prev: ["export"], next: "*" },
+			{ blankLine: "always", prev: "*", next: ["export"] },
+			{
+				blankLine: "any",
+				prev: ["export"],
+				next: ["export"],
+			},
+			// Require newline between blocks of `import` and any lines between `import`
+			{ blankLine: "always", prev: ["import"], next: "*" },
+			{ blankLine: "always", prev: "*", next: ["import"] },
+			{
+				blankLine: "any",
+				prev: ["import"],
+				next: ["import"],
+			},
+		],
+	},
+};
+
+export default {
+	"stylistic/recommended": recommendedConfig,
+};

configs/stylistic.js

@@ -1,13 +1,23 @@
 "use strict";
 
 const code = require("./module.cjs");
+// eslint-disable-next-line no-unused-vars, import/extensions
+const myOtherCode = require("./module.js");
 const otherSum = require("./module");
 
 // eslint-disable-next-line import/no-unresolved
 require("./unknown");
 
 require("./style.css");
 
+const { aaa } = require("./module.cjs");
+
+otherSum(aaa, 2);
+
+const { bbb } = require("./module.cjs");
+
+otherSum(bbb, 2);
+
 code();
 otherSum(1, 2);
 

validation/code.cjs

@@ -1,9 +1,10 @@
 import { CLIEngine, linter } from "eslint";
 import sumFn from "./module.js";
 import * as names from "./named-exports.js";
-
 // eslint-disable-next-line import/named, no-duplicate-imports
 import { notFoo } from "./module.js";
+// eslint-disable-next-line no-unused-vars, import/extensions, import/no-unresolved
+import { myVar } from "./without-extension";
 
 import "./style.css";
 
@@ -939,3 +940,9 @@ export default function myFunctionDeclaration() {
 export const myArrayFunction = () => {
 	// ...
 };
+
+export const aaa = 1;
+
+sumFn(1, 2);
+
+export const bbb = 1;

validation/code.js

@@ -1,8 +1,28 @@
 "use strict";
 
+/**
+ * @returns {void}
+ */
+function test() {
+	// Nothing
+}
+
 /**
  * @returns {string} result
  */
 module.exports = function test() {
 	return "test";
 };
+
+/**
+ * @returns {string} result
+ */
+module.exports.other = function other() {
+	return "test";
+};
+
+module.exports.aaa = 1;
+
+test();
+
+module.exports.bbb = 1;