Skip to content

Commit 4607d8f

Browse files
fix: apply DOM rules only for the browser target (#61)
1 parent 71b3d96 commit 4607d8f

File tree

2 files changed

+28
-7
lines changed

2 files changed

+28
-7
lines changed

configs/browser.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,20 @@ const recommendedBrowserConfig = {
1111
import: importPlugin,
1212
},
1313
rules: {
14+
"unicorn/prefer-dom-node-append": "error",
15+
16+
"unicorn/prefer-dom-node-dataset": "error",
17+
18+
"unicorn/prefer-dom-node-remove": "error",
19+
20+
"unicorn/prefer-dom-node-text-content": "error",
21+
22+
"unicorn/prefer-modern-dom-apis": "error",
23+
24+
"unicorn/prefer-keyboard-event-key": "error",
25+
26+
"unicorn/prefer-query-selector": "error",
27+
1428
"import/extensions": ["error", "always", { ignorePackages: true }],
1529
},
1630
};

configs/javascript.js

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -885,13 +885,17 @@ const unicornRules = {
885885

886886
"unicorn/prefer-default-parameters": "error",
887887

888-
"unicorn/prefer-dom-node-append": "error",
888+
// Not here, define only for `browsers`
889+
// "unicorn/prefer-dom-node-append": "error",
889890

890-
"unicorn/prefer-dom-node-dataset": "error",
891+
// Not here, define only for `browsers`
892+
// "unicorn/prefer-dom-node-dataset": "error",
891893

892-
"unicorn/prefer-dom-node-remove": "error",
894+
// Not here, define only for `browsers`
895+
// "unicorn/prefer-dom-node-remove": "error",
893896

894-
"unicorn/prefer-dom-node-text-content": "error",
897+
// Not here, define only for `browsers`
898+
// "unicorn/prefer-dom-node-text-content": "error",
895899

896900
"unicorn/prefer-event-target": "error",
897901

@@ -907,7 +911,8 @@ const unicornRules = {
907911
// No need
908912
// "unicorn/prefer-json-parse-buffer": "off",
909913

910-
"unicorn/prefer-keyboard-event-key": "error",
914+
// Not here, define only for `browsers`
915+
// "unicorn/prefer-keyboard-event-key": "error",
911916

912917
"unicorn/prefer-logical-operator-over-ternary": "error",
913918

@@ -918,7 +923,8 @@ const unicornRules = {
918923
// `| 0` is faster
919924
// "unicorn/prefer-math-trunc": "off",
920925

921-
"unicorn/prefer-modern-dom-apis": "error",
926+
// Not here, define only for `browsers`
927+
// "unicorn/prefer-modern-dom-apis": "error",
922928

923929
"unicorn/prefer-modern-math-apis": "error",
924930

@@ -941,7 +947,8 @@ const unicornRules = {
941947

942948
"unicorn/prefer-prototype-methods": "error",
943949

944-
"unicorn/prefer-query-selector": "error",
950+
// Not here, define only for `browsers`
951+
// "unicorn/prefer-query-selector": "error",
945952

946953
// No need
947954
// "unicorn/prefer-reflect-apply": "off",

0 commit comments

Comments
 (0)