Skip to content

Commit c600bab

Browse files
fix: disable n/no-extraneous-import due import/no-extraneous-dependencies (#85)
1 parent f54145f commit c600bab

File tree

6 files changed

+16
-7
lines changed

6 files changed

+16
-7
lines changed

configs/node.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ const commonRules = {
2929
// From recommended
3030
// "n/no-exports-assign": "error",
3131

32-
// From recommended
33-
// "n/no-extraneous-import": "error",
32+
// We have `import/no-extraneous-dependencies` rule
33+
"n/no-extraneous-import": "off",
3434

35-
// From recommended
36-
// "n/no-extraneous-require": "error",
35+
// We have `import/no-extraneous-dependencies` rule
36+
"n/no-extraneous-require": "off",
3737

3838
// Deprecated
3939
// "n/no-hide-core-modules": "error",

eslint.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { defineConfig } from "eslint/config";
2-
import configs from "../eslint-config-webpack/configs.js";
3-
import config from "../eslint-config-webpack/index.js";
2+
import configs from "./configs.js";
3+
import config from "./index.js";
44

55
export default defineConfig([
66
{

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

validation/code.cjs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ require("./unknown.unknown");
1919

2020
require("./style.css");
2121

22+
// eslint-disable-next-line no-unused-vars, import/order, import/no-extraneous-dependencies
23+
const scope = require("eslint-scope");
24+
2225
code();
2326
otherSum(1, 2);
2427

validation/code.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ import { myVar } from "./without-extension";
99

1010
import "./style.css";
1111

12+
// eslint-disable-next-line no-unused-vars, import/order, import/no-extraneous-dependencies
13+
import * as scope from "eslint-scope";
14+
1215
notFoo();
1316

1417
const result = sumFn(1, 2);

validation/code.mjs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ import code from "./module.cjs";
55
import { aaa, bbb } from "./module.cjs";
66
import myOtherCode from "./module.js";
77

8+
// eslint-disable-next-line no-unused-vars, import/order, import/no-extraneous-dependencies
9+
import * as scope from "eslint-scope";
10+
811
// eslint-disable-next-line import/no-unresolved
912
import("./unknown.ext");
1013

0 commit comments

Comments
 (0)