fix: fail on error and fail on warning

Author: ricardogobbosouza

src/index.js

@@ -150,29 +150,34 @@ class ESLintWebpackPlugin {
       });
 
       // await and interpret results
-      compilation.hooks.additionalAssets.tapPromise(this.key, processResults);
-
-      async function processResults() {
-        const { errors, warnings, generateReportAsset } = await report();
-
-        if (warnings && !options.failOnWarning) {
-          // @ts-ignore
-          compilation.warnings.push(warnings);
-        } else if (warnings) {
-          // @ts-ignore
-          compilation.errors.push(warnings);
-        }
-
-        if (errors && !options.failOnError) {
-          // @ts-ignore
-          compilation.warnings.push(errors);
-        } else if (errors) {
-          // @ts-ignore
-          compilation.errors.push(errors);
-        }
-
-        if (generateReportAsset) await generateReportAsset(compilation);
-      }
+      compilation.hooks.additionalAssets.tapAsync(
+        this.key,
+        async function (callback) {
+          const { errors, warnings, generateReportAsset } = await report();
+
+          if (warnings) {
+            // @ts-ignore
+            compilation.warnings.push(warnings);
+          }
+
+          if (errors) {
+            // @ts-ignore
+            compilation.errors.push(errors);
+          }
+
+          if (generateReportAsset) {
+            await generateReportAsset(compilation);
+          }
+
+         if (warnings && options.failOnWarning) {
+           callback(warnings);
+         } else if (errors && options.failOnError) {
+           callback(errors);
+         } else {
+           callback();
+         }
+        },
+      );
     });
   }
 

test/fail-on-error.test.js

@@ -4,21 +4,20 @@ describe('fail on error', () => {
   it('should emits errors', async () => {
     const compiler = pack('error', { failOnError: true });
 
-    const stats = await compiler.runAsync();
-    expect(stats.hasErrors()).toBe(true);
+    await expect(compiler.runAsync()).rejects.toThrow('error');
   });
 
   it('should emit warnings when disabled', async () => {
     const compiler = pack('error', { failOnError: false });
 
     const stats = await compiler.runAsync();
-    expect(stats.hasErrors()).toBe(false);
-    expect(stats.hasWarnings()).toBe(true);
+    expect(stats.hasErrors()).toBe(true);
   });
 
   it('should correctly identifies a success', async () => {
     const compiler = pack('good', { failOnError: true });
 
-    await compiler.runAsync();
+    const stats = await compiler.runAsync();
+    expect(stats.hasErrors()).toBe(false);
   });
 });

test/fail-on-warning.test.js

@@ -4,8 +4,7 @@ describe('fail on warning', () => {
   it('should emits errors', async () => {
     const compiler = pack('warn', { failOnWarning: true });
 
-    const stats = await compiler.runAsync();
-    expect(stats.hasErrors()).toBe(true);
+    await expect(compiler.runAsync()).rejects.toThrow('warning');
   });
 
   it('should correctly identifies a success', async () => {

test/lint-dirty-modules-only.test.js

@@ -41,8 +41,7 @@ describe('lint dirty modules only', () => {
       expect(stats.hasErrors()).toBe(true);
       const { errors } = stats.compilation;
       expect(errors.length).toBe(1);
-      const [{ message }] = errors;
-      expect(message).toEqual(expect.stringMatching('no-unused-vars'));
+      expect(stats.compilation.errors[0].message).toEqual(expect.stringMatching('no-unused-vars'));
       done();
     }
   });

test/multiple-instances.test.js

@@ -48,9 +48,7 @@ describe('multiple instances', () => {
       },
     );
 
-    const stats = await compiler.runAsync();
-    expect(stats.hasWarnings()).toBe(false);
-    expect(stats.hasErrors()).toBe(true);
+    await expect(compiler.runAsync()).rejects.toThrow();
   });
 
   it('should fail on second instance', async () => {
@@ -73,8 +71,6 @@ describe('multiple instances', () => {
       },
     );
 
-    const stats = await compiler.runAsync();
-    expect(stats.hasWarnings()).toBe(false);
-    expect(stats.hasErrors()).toBe(true);
+    await expect(compiler.runAsync()).rejects.toThrow();
   });
 });

test/utils/conf.js

@@ -21,6 +21,7 @@ export default (entry, pluginConf = {}, webpackConf = {}) => {
         ignore: false,
         // TODO: update tests to run both states: test.each([[{threads: false}], [{threads: true}]])('it should...', async ({threads}) => {...})
         threads: true,
+        failOnError: false,
         ...pluginConf,
       }),
     ],