test: fix

Author: alexander-akait

src/linter.js

@@ -184,7 +184,7 @@ async function linter(key, options, compilation) {
   /** @type {ESLint} */
   let eslint;
 
-  /** @type {(files: string|string[]) => Promise<LintResult[]>} */
+  /** @type {(files: string | string[]) => Promise<LintResult[]>} */
   let lintFiles;
 
   /** @type {() => Promise<void>} */

test/config-for-tests/.eslintrc.js

@@ -1,15 +1,17 @@
 module.exports = {
-  root: true,
+  ignorePatterns: ["**/ignore.js"],
   globals: {
     __dirname: "readonly",
     __filename: "readonly",
     exports: "writable",
     module: "readonly",
     require: "readonly",
+    console: "readonly",
   },
   parserOptions: {
     ecmaVersion: 2018,
     env: {
+      browser: true,
       node: true,
       es6: true,
     },

test/eslintignore.test.js renamed to test/ignore.test.js

@@ -1,13 +1,20 @@
+import eslint from "eslint";
 import ESLintError from "../src/ESLintError";
-
 import pack from "./utils/pack";
 
 describe("eslintignore", () => {
   it("should ignores files present in .eslintignore", async () => {
-    const compiler = pack("ignore", {
-      ignore: true,
-      ignorePatterns: ["**/ignore.js"],
-    });
+    const pluginConfig =
+      Number.parseFloat(eslint.ESLint.version) >= 9
+        ? {
+            ignore: true,
+            ignorePatterns: ["**/ignore.js"],
+          }
+        : {
+            ignore: true,
+          };
+
+    const compiler = pack("ignore", pluginConfig);
 
     const stats = await compiler.runAsync();
     expect(stats.hasWarnings()).toBe(false);

test/multiple-instances.test.js

@@ -1,9 +1,15 @@
 import { join } from "node:path";
-
+import eslint from "eslint";
 import ESLintPlugin from "../src";
-
 import pack from "./utils/pack";
 
+const configType =
+  Number.parseFloat(eslint.ESLint.version) >= 9 ? "flat" : "eslintrc";
+const config =
+  Number.parseFloat(eslint.ESLint.version) >= 9
+    ? join(__dirname, "./config-for-tests/eslint.config.mjs")
+    : join(__dirname, "./config-for-tests/.eslintrc.js");
+
 describe("multiple instances", () => {
   it("should don't fail", async () => {
     const compiler = pack(
@@ -12,18 +18,14 @@ describe("multiple instances", () => {
       {
         plugins: [
           new ESLintPlugin({
-            overrideConfigFile: join(
-              __dirname,
-              "./config-for-tests/eslint.config.mjs",
-            ),
+            configType,
+            overrideConfigFile: config,
             ignore: false,
             exclude: "error.js",
           }),
           new ESLintPlugin({
-            overrideConfigFile: join(
-              __dirname,
-              "./config-for-tests/eslint.config.mjs",
-            ),
+            configType,
+            overrideConfigFile: config,
             ignore: false,
             exclude: "error.js",
           }),
@@ -43,18 +45,14 @@ describe("multiple instances", () => {
       {
         plugins: [
           new ESLintPlugin({
-            overrideConfigFile: join(
-              __dirname,
-              "./config-for-tests/eslint.config.mjs",
-            ),
+            configType,
+            overrideConfigFile: config,
             ignore: false,
             exclude: "good.js",
           }),
           new ESLintPlugin({
-            overrideConfigFile: join(
-              __dirname,
-              "./config-for-tests/eslint.config.mjs",
-            ),
+            configType,
+            overrideConfigFile: config,
             ignore: false,
             exclude: "error.js",
           }),
@@ -72,18 +70,14 @@ describe("multiple instances", () => {
       {
         plugins: [
           new ESLintPlugin({
-            overrideConfigFile: join(
-              __dirname,
-              "./config-for-tests/eslint.config.mjs",
-            ),
+            configType,
+            overrideConfigFile: config,
             ignore: false,
             exclude: "error.js",
           }),
           new ESLintPlugin({
-            overrideConfigFile: join(
-              __dirname,
-              "./config-for-tests/eslint.config.mjs",
-            ),
+            configType,
+            overrideConfigFile: config,
             ignore: false,
             exclude: "good.js",
           }),

test/threads.test.js

@@ -1,6 +1,6 @@
 /* eslint-env jest */
 import { join } from "node:path";
-
+import eslint from "eslint";
 import { loadESLint, loadESLintThreaded } from "../src/getESLint";
 
 describe("Threading", () => {
@@ -23,11 +23,12 @@ describe("Threading", () => {
   it("threaded should lint files", async () => {
     const threaded = await loadESLintThreaded("bar", 1, {
       ignore: false,
-      configType: "flat",
-      overrideConfigFile: join(
-        __dirname,
-        "./config-for-tests/eslint.config.mjs",
-      ),
+      configType:
+        Number.parseFloat(eslint.ESLint.version) >= 9 ? "flat" : "eslintrc",
+      overrideConfigFile:
+        Number.parseFloat(eslint.ESLint.version) >= 9
+          ? join(__dirname, "./config-for-tests/eslint.config.mjs")
+          : join(__dirname, "./config-for-tests/.eslintrc.js"),
     });
     try {
       const [good, bad] = await Promise.all([

test/utils/conf.js

@@ -15,6 +15,8 @@ export default (entry, pluginConf = {}, webpackConf = {}) => {
     },
     plugins: [
       new ESLintPlugin({
+        // Do not cache for tests
+        cache: false,
         configType:
           Number.parseFloat(eslint.ESLint.version) >= 9 ? "flat" : "eslintrc",
         overrideConfigFile: