fix: fails when failOnError or failOnWarning enabled (#72)

* fix: fails when `failOnError` or `failOnWarning` enabled

* fix: failOnError and failOnWarning

Author: ricardogobbosouza

README.md

@@ -188,9 +188,9 @@ The warnings found will always be emitted, to disable set to `false`.
 #### `failOnError`
 
 - Type: `Boolean`
-- Default: `false`
+- Default: `true`
 
-Will cause the module build to fail if there are any errors, if set to `true`.
+Will cause the module build to fail if there are any errors, to disable set to `false`.
 
 #### `failOnWarning`
 

src/ESLintError.js

@@ -1,7 +1,4 @@
-// @ts-ignore
-import WebpackError from 'webpack/lib/WebpackError';
-
-export default class ESLintError extends WebpackError {
+class ESLintError extends Error {
   /**
    * @param {string=} messages
    */
@@ -11,3 +8,5 @@ export default class ESLintError extends WebpackError {
     this.stack = '';
   }
 }
+
+export default ESLintError;

src/index.js

@@ -109,18 +109,25 @@ class ESLintWebpackPlugin {
 
       // Gather Files to lint
       compilation.hooks.succeedModule.tap(ESLINT_PLUGIN, processModule);
+
       // await and interpret results
-      compilation.hooks.afterSeal.tapPromise(ESLINT_PLUGIN, processResults);
+      compilation.hooks.additionalAssets.tapPromise(
+        ESLINT_PLUGIN,
+        processResults
+      );
 
       async function processResults() {
         const { errors, warnings, generateReportAsset } = await report();
 
-        if (warnings) {
+        if (warnings && !options.failOnWarning) {
           // @ts-ignore
           compilation.warnings.push(warnings);
+        } else if (warnings && options.failOnWarning) {
+          // @ts-ignore
+          compilation.errors.push(warnings);
         }
 
-        if (errors) {
+        if (errors && options.failOnError) {
           // @ts-ignore
           compilation.errors.push(errors);
         }

src/linter.js

@@ -94,12 +94,6 @@ export default function linter(key, options, compilation) {
       parseResults(options, results)
     );
 
-    if (options.failOnError && errors) {
-      throw errors;
-    } else if (options.failOnWarning && warnings) {
-      throw warnings;
-    }
-
     return {
       errors,
       warnings,

src/options.js

@@ -50,6 +50,7 @@ export function getOptions(pluginOptions) {
     extensions: 'js',
     emitError: true,
     emitWarning: true,
+    failOnError: true,
     ...pluginOptions,
     ...(pluginOptions.quiet ? { emitError: true, emitWarning: false } : {}),
   };

src/options.json

@@ -23,7 +23,7 @@
       "anyOf": [{ "type": "string" }, { "type": "array" }]
     },
     "failOnError": {
-      "description": "Will cause the module build to fail if there are any errors, if set to `true`.",
+      "description": "Will cause the module build to fail if there are any errors, to disable set to `false`.",
       "type": "boolean"
     },
     "failOnWarning": {

test/fail-on-error.test.js

@@ -4,8 +4,9 @@ describe('fail on error', () => {
   it('should emits errors', (done) => {
     const compiler = pack('error', { failOnError: true });
 
-    compiler.run((err) => {
-      expect(err.message).toContain('error.js');
+    compiler.run((err, stats) => {
+      expect(err).toBeNull();
+      expect(stats.hasErrors()).toBe(true);
       done();
     });
   });

test/fail-on-warning.test.js

@@ -4,8 +4,9 @@ describe('fail on warning', () => {
   it('should emits errors', (done) => {
     const compiler = pack('warn', { failOnWarning: true });
 
-    compiler.run((err) => {
-      expect(err.message).toContain('warn.js');
+    compiler.run((err, stats) => {
+      expect(err).toBeNull();
+      expect(stats.hasErrors()).toBe(true);
       done();
     });
   });