feat: remove special handling of cache configuration

In webpack verion 4 special code was necessary to make the cache work with grunts multi-target system. The cache plugin in version 4 was storing one global cache for all compilers it was attached to. In webpack 5 this is not neccessary anymore as the cache now creates a new storage for each compiler.

Author: danez

src/options/WebpackOptionHelper.js

@@ -12,23 +12,7 @@ class WebpackOptionHelper extends OptionHelper {
     const options = this.getOptions();
 
     if (Array.isArray(options)) {
-      return options.map((opt) => this.filterOptions(opt));
-    }
-
-    return this.filterOptions(options);
-  }
-
-  filterOptions(options) {
-    if (!options.watch) {
-      // ensure cache is disabled in non watch mode, as we add our own CachePlugin to support
-      // multiple targets in one run with different caches
-      options.cache = false;
-    }
-
-    // ensure that when we send the cache option to webpack in watch mode it is not the function
-    // TODO: this is workaround and should be handled in a more generic way
-    if (typeof options.cache === "function") {
-      options.cache = options.cache(options);
+      return options.map((opt) => this.filterGruntOptions(opt));
     }
 
     return this.filterGruntOptions(options);

src/options/__tests__/WebpackOptionHelper.test.js

@@ -1,42 +1,6 @@
 import WebpackOptionHelper from "../WebpackOptionHelper";
 
 describe("WebpackOptionHelper", () => {
-  test("cache stays enabled in watch mode", () => {
-    const options = { watch: true, cache: true };
-    const helper = new WebpackOptionHelper();
-
-    const result = helper.filterOptions(options);
-
-    expect(result.cache).toBe(true);
-  });
-
-  test("cache is enabled in watch mode by default", () => {
-    const options = { watch: true, cache: () => true };
-    const helper = new WebpackOptionHelper();
-
-    const result = helper.filterOptions(options);
-
-    expect(result.cache).toBe(true);
-  });
-
-  test("cache is disabled in normal mode by default", () => {
-    const options = { watch: false, cache: () => true };
-    const helper = new WebpackOptionHelper();
-
-    const result = helper.filterOptions(options);
-
-    expect(result.cache).toBe(false);
-  });
-
-  test("cache is disabled in normal mode", () => {
-    const options = { watch: false, cache: true };
-    const helper = new WebpackOptionHelper();
-
-    const result = helper.filterOptions(options);
-
-    expect(result.cache).toBe(false);
-  });
-
   test("watch options is part of webpack options", () => {
     const options = {
       watch: true,

src/options/default.js

@@ -26,12 +26,6 @@ const webpackOptions = {
     cachedAssets: false,
     colors: true,
   },
-  cache: (options) => {
-    // if watch enabled also default to cache true
-    return Array.isArray(options)
-      ? options.some((option) => option.watch)
-      : !!options.watch;
-  },
 };
 
 const webpackDevServerOptions = {

src/plugins/CachePluginFactory.js

@@ -3,11 +3,9 @@
 const webpack = require("webpack");
 const pkg = require("../package.json");
 const OptionHelper = require("../src/options/WebpackOptionHelper");
-const CachePluginFactory = require("../src/plugins/CachePluginFactory");
 const ProgressPluginFactory = require("../src/plugins/ProgressPluginFactory");
 
 module.exports = (grunt) => {
-  const cachePluginFactory = new CachePluginFactory();
   const processPluginFactory = new ProgressPluginFactory(grunt);
 
   grunt.registerTask(
@@ -59,9 +57,6 @@ module.exports = (grunt) => {
 
           const compiler = webpack(webpackOptions);
 
-          if (opts.cache) {
-            cachePluginFactory.addPlugin(target, compiler);
-          }
           if (opts.progress) {
             processPluginFactory.addPlugin(compiler, webpackOptions);
           }