fix(index): check if document is defined
#149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alexander-akait
requested changes
May 16, 2018
|
Also please accept CLA |
michael-ciniawsky
changed the title
document is defined
|
@evilebottnawi / @michael-ciniawsky : Whats the alternative here then for ssr build? AFAIK adding |
|
@prate3k sorry for delay, problem still exists? |
|
Do not run plugin in non browsers env, if you have problem with SSR please open new issue with reproducible test repo, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Rendering bundles targetting nodejs rather than a browser still inserts javascript that assumes it will be executed in an environment that has
documentdefined.Breaking Changes
Additional Info