fix: ignore invalid before values (#198)

Author: jianyi-gronk

lib/Hook.js

@@ -152,6 +152,13 @@ class Hook {
 		} else if (Array.isArray(item.before)) {
 			before = new Set(item.before);
 		}
+		if (before) {
+			for (const name of before) {
+				if (!this.taps.some((tap) => tap.name === name)) {
+					before.delete(name);
+				}
+			}
+		}
 		let stage = 0;
 		if (typeof item.stage === "number") {
 			stage = item.stage;

lib/__tests__/Hook.js

@@ -107,4 +107,48 @@ describe("Hook", () => {
 			new Error("Missing name for tap")
 		);
 	});
+
+	it("should ignore invalid before values", () => {
+		const hook = new SyncHook();
+
+		const calls = [];
+
+		hook.tap("A", () => calls.push("A"));
+
+		hook.tap(
+			{
+				name: "B",
+				before: "C"
+			},
+			() => calls.push("B")
+		);
+
+		hook.tap(
+			{
+				name: "C",
+				before: [" "]
+			},
+			() => calls.push("C")
+		);
+
+		hook.tap(
+			{
+				name: "D",
+				before: {}
+			},
+			() => calls.push("D")
+		);
+
+		hook.tap(
+			{
+				name: "E",
+				before: null
+			},
+			() => calls.push("E")
+		);
+
+		calls.length = 0;
+		hook.call();
+		expect(calls).toEqual(["A", "B", "C", "D", "E"]);
+	});
 });