Skip to content

Commit 27593cd

Browse files
committed
Replace opener with open
1 parent 0cab01f commit 27593cd

File tree

4 files changed

+113
-50
lines changed

4 files changed

+113
-50
lines changed

package-lock.json

Lines changed: 104 additions & 43 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"debounce": "^2.0.0",
4141
"escape-string-regexp": "^4.0.0",
4242
"html-escaper": "^2.0.2",
43-
"opener": "^1.5.2",
43+
"open": "^8.4.2",
4444
"picocolors": "^1.0.0",
4545
"sirv": "^3.0.2",
4646
"ws": "^8.18.3"

src/utils.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
const {inspect, types} = require('util');
2-
const opener = require('opener');
2+
const open = require('open');
33

44
const MONTHS = ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec'];
55

@@ -56,12 +56,12 @@ exports.defaultAnalyzerUrl = function (options) {
5656
};
5757

5858
/**
59-
* Calls opener on a URI, but silently try / catches it.
59+
* Calls open on a URI, but silently try / catches it.
6060
*/
61-
exports.open = function (uri, logger) {
61+
exports.open = async function (uri, logger) {
6262
try {
63-
opener(uri);
63+
await open(uri);
6464
} catch (err) {
65-
logger.debug(`Opener failed to open "${uri}":\n${err}`);
65+
logger.debug(`Open failed to open "${uri}":\n${err}`);
6666
}
6767
};

src/viewer.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ async function startServer(bundleStats, opts) {
9595
);
9696

9797
if (openBrowser) {
98+
// We don't await here as the server is already running and
99+
// we don't want to stop the process even if browser fails to open.
98100
open(url, logger);
99101
}
100102
});
@@ -169,7 +171,7 @@ async function generateReport(bundleStats, opts) {
169171
logger.info(`${bold('Webpack Bundle Analyzer')} saved report to ${bold(reportFilepath)}`);
170172

171173
if (openBrowser) {
172-
open(`file://${reportFilepath}`, logger);
174+
await open(`file://${reportFilepath}`, logger);
173175
}
174176
}
175177

0 commit comments

Comments
 (0)