fix: handleValueChange.cancel is not a function (#625)

life2015 · valscion · web-flow · commit 4c424d54255c · 2023-11-16T09:14:30.000+02:00
* fix: handleValueChange not a function

* Move changelog to correct place

---------

Co-authored-by: Vesa Laakso &lt;482561+valscion@users.noreply.github.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,9 @@ _Note: Gaps between patch versions are faulty, broken or test releases._
 
 ## UNRELEASED
 
+* **Bug Fix**
+  * fix `this.handleValueChange.cancel()` is not a function ([#611](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/625) by [@life2015](https://github.com/life2015))
+
 ## 4.10.0
 
 * **Improvement**
diff --git a/client/components/Search.jsx b/client/components/Search.jsx
@@ -14,7 +14,7 @@ export default class Search extends PureComponent {
   }
 
   componentWillUnmount() {
-    this.handleValueChange.cancel();
+    this.handleValueChange.clear();
   }
 
   render() {
@@ -79,7 +79,7 @@ export default class Search extends PureComponent {
   }
 
   clear() {
-    this.handleValueChange.cancel();
+    this.handleValueChange.clear();
     this.informChange('');
     this.input.value = '';
   }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ export default class Search extends PureComponent {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`componentWillUnmount() {`
`17`		`- this.handleValueChange.cancel();`
	`17`	`+ this.handleValueChange.clear();`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`render() {`
`@@ -79,7 +79,7 @@ export default class Search extends PureComponent {`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`clear() {`
`82`		`- this.handleValueChange.cancel();`
	`82`	`+ this.handleValueChange.clear();`
`83`	`83`	`this.informChange('');`
`84`	`84`	`this.input.value = '';`
`85`	`85`	`}`