build!: the minimum required Node.js version is 18.12.0 (#4291)

snitin315 · alexander-akait · commit 15b29522a297 · 2024-12-19T02:33:36.000+03:00
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -68,12 +68,6 @@ jobs:
         webpack-version: [latest]
         dev-server-version: [latest]
         include:
-          - node-version: 14.x
-            os: ubuntu-latest
-            dev-server-version: 4
-          - node-version: 16.x
-            os: ubuntu-latest
-            dev-server-version: 4
           - node-version: 18.x
             os: ubuntu-latest
             dev-server-version: 4
diff --git a/package.json b/package.json
@@ -12,7 +12,7 @@
     "url": "https://opencollective.com/webpack"
   },
   "engines": {
-    "node": ">=14.15.0"
+    "node": ">=18.12.0"
   },
   "keywords": [
     "webpack",
diff --git a/packages/configtest/package.json b/packages/configtest/package.json
@@ -6,7 +6,7 @@
   "types": "lib/index.d.ts",
   "license": "MIT",
   "engines": {
-    "node": ">=14.15.0"
+    "node": ">=18.12.0"
   },
   "publishConfig": {
     "access": "public"
diff --git a/packages/generators/package.json b/packages/generators/package.json
@@ -7,7 +7,7 @@
   "keywords": [],
   "license": "MIT",
   "engines": {
-    "node": ">=14.15.0"
+    "node": ">=18.12.0"
   },
   "publishConfig": {
     "access": "public"
diff --git a/packages/info/package.json b/packages/info/package.json
@@ -6,7 +6,7 @@
   "types": "lib/index.d.ts",
   "license": "MIT",
   "engines": {
-    "node": ">=14.15.0"
+    "node": ">=18.12.0"
   },
   "publishConfig": {
     "access": "public"
diff --git a/packages/serve/package.json b/packages/serve/package.json
@@ -15,7 +15,7 @@
   "homepage": "https://github.com/webpack/webpack-cli/tree/master/packages/serve",
   "license": "MIT",
   "engines": {
-    "node": ">=14.15.0"
+    "node": ">=18.12.0"
   },
   "files": [
     "lib"
diff --git a/packages/webpack-cli/package.json b/packages/webpack-cli/package.json
@@ -18,7 +18,7 @@
   },
   "main": "./lib/index.js",
   "engines": {
-    "node": ">=14.15.0"
+    "node": ">=18.12.0"
   },
   "keywords": [
     "webpack",
diff --git a/test/build/config-format/babel-commonjs/package.json b/test/build/config-format/babel-commonjs/package.json
@@ -1,5 +1,5 @@
 {
   "engines": {
-    "node": ">=14.15.0"
+    "node": ">=18.12.0"
   }
 }
diff --git a/test/build/config-format/babel-esm/package.json b/test/build/config-format/babel-esm/package.json
@@ -0,0 +1,6 @@
+{
+  "type": "module",
+  "engines": {
+    "node": ">=18.12.0"
+  }
+}
diff --git a/test/build/config-format/typescript-esnext-mjs/package.json b/test/build/config-format/typescript-esnext-mjs/package.json
@@ -1,6 +1,6 @@
 {
   "type": "module",
   "engines": {
-    "node": ">=14.15.0"
+    "node": ">=18.12.0"
   }
 }
diff --git a/test/build/config-format/typescript-esnext/package.json b/test/build/config-format/typescript-esnext/package.json
@@ -1,6 +1,6 @@
 {
   "type": "module",
   "engines": {
-    "node": ">=14.15.0"
+    "node": ">=18.12.0"
   }
 }
diff --git a/test/build/config-format/typescript-esnext/typescript.test.js b/test/build/config-format/typescript-esnext/typescript.test.js
@@ -5,13 +5,9 @@ const { resolve } = require("path");
 
 describe("webpack cli", () => {
   it("should support typescript esnext file", async () => {
-    const majorNodeVersion = process.version.slice(1, 3);
     const env = { ...process.env };
 
-    if (majorNodeVersion >= 18) {
-      // Node.js 20+ change logic, so we need to force esm config loading for test purposes
-      env.WEBPACK_CLI_FORCE_LOAD_ESM_CONFIG = true;
-    }
+    env.WEBPACK_CLI_FORCE_LOAD_ESM_CONFIG = true;
 
     const { exitCode, stderr, stdout } = await run(__dirname, ["-c", "./webpack.config.ts"], {
       nodeOptions: ["--experimental-loader=ts-node/esm"],
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"engines": {`
`3`		`- "node": ">=14.15.0"`
	`3`	`+ "node": ">=18.12.0"`
`4`	`4`	`}`
`5`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"type": "module",`
`3`	`3`	`"engines": {`
`4`		`- "node": ">=14.15.0"`
	`4`	`+ "node": ">=18.12.0"`
`5`	`5`	`}`
`6`	`6`	`}`