refactor: external command (#1867)

Co-authored-by: Nitin Kumar <[email protected]>

Author: rishabh3112

packages/package-utils/__tests__/index.test.ts

@@ -3,7 +3,7 @@
 jest.mock('@webpack-cli/package-utils');
 
 import { packageExists, promptInstallation } from '@webpack-cli/package-utils';
-import ExternalCommand from '../../webpack-cli/lib/commands/ExternalCommand';
+import { run } from '../../webpack-cli/lib/commands/resolveCommand';
 
 describe('@webpack-cli/package-utils', () => {
     it('should check existence of package', () => {
@@ -16,6 +16,6 @@ describe('@webpack-cli/package-utils', () => {
         (promptInstallation as jest.Mock).mockImplementation(() => {
             throw new Error();
         });
-        await expect(ExternalCommand.run('info')).resolves.not.toThrow();
+        await expect(run('info')).resolves.not.toThrow();
     });
 });

packages/webpack-cli/lib/commands/ExternalCommand.js

@@ -0,0 +1,38 @@
+const { yellow, cyan } = require('colorette');
+const logger = require('../utils/logger');
+const execa = require('execa');
+const { packageExists, promptInstallation } = require('@webpack-cli/package-utils');
+
+const packagePrefix = '@webpack-cli';
+const runCommand = async (command, args = []) => {
+    const executedCommand = await execa(command, args, {
+        stdio: 'inherit',
+        shell: true,
+    });
+    return new Promise((resolve, reject) => {
+        executedCommand.on('error', (error) => {
+            reject(error);
+        });
+
+        executedCommand.on('exit', () => {
+            resolve();
+        });
+    });
+};
+
+const run = async (name, ...args) => {
+    const scopeName = packagePrefix + '/' + name;
+    let pkgLoc = packageExists(scopeName);
+    if (!pkgLoc) {
+        try {
+            pkgLoc = await promptInstallation(`${scopeName}`, () => {
+                logger.error(`The command moved into a separate package: ${yellow(scopeName)}\n`);
+            });
+        } catch (err) {
+            logger.error(`Action Interrupted, use ${cyan('webpack-cli help')} to see possible commands.`);
+        }
+    }
+    return pkgLoc ? require(scopeName).default(...args) : null;
+};
+
+module.exports = { run, runCommand };

packages/webpack-cli/lib/commands/resolveCommand.js

@@ -27,7 +27,7 @@ function argParser(options, args, argsOnly = false, name = '', helpFunction) {
             .allowUnknownOption(true)
             .action(async () => {
                 const cliArgs = args.slice(args.indexOf(cmd.name) + 1 || args.indexOf(cmd.alias) + 1);
-                return await require('../commands/ExternalCommand').run(defaultCommands[cmd.name], ...cliArgs);
+                return await require('../commands/resolveCommand').run(defaultCommands[cmd.name], ...cliArgs);
             });
         return parser;
     }, parser);