On windows path spaces should resolve to %20 (#288)

* fixes #284, on windows path spaces should resolve to %20

* disable linting failures temporarily

* try out windows webpack config

* some output for debugging

* adjusting tests for windows

* tests for bugfix passing, removing debugging statements

* turning on all the tests

* coverage tweaks, since coverage doesn't run on windows

Author: shellscape

lib/util.js

@@ -65,6 +65,7 @@ module.exports = {
     const localPrefix = parse(publicPath || '/', false, true);
     const urlObject = parse(url);
     let filename;
+    let result = '';
 
     // publicPath has the hostname that is not the same as request url's, should fail
     if (localPrefix.hostname !== null && urlObject.hostname !== null &&
@@ -99,7 +100,15 @@ module.exports = {
     }
 
     // if no matches, use outputPath as filename
-    return querystring.unescape(uri);
+    result = querystring.unescape(uri);
+
+    // fixes #284, on windows path spaces should resolve to %20
+    /* istanbul ignore if */
+    if (process.platform === 'win32') {
+      result = result.replace(/\s/g, '%20');
+    }
+
+    return result;
   },
 
   handleRangeHeaders(content, req, res) {

test/tests/util.js

@@ -3,6 +3,8 @@
 const assert = require('assert');
 const { getFilenameFromUrl } = require('../../lib/util');
 
+const isWindows = process.platform === 'win32';
+
 function testUrl(options) {
   const url = getFilenameFromUrl(options.publicPath, options, options.url);
   assert.equal(url, options.expected);
@@ -119,7 +121,8 @@ describe('GetFilenameFromUrl', () => {
       url: '/pathname%20with%20spaces.js',
       outputPath: '/',
       publicPath: '/',
-      expected: '/pathname with spaces.js'
+      // ref #284 - windows paths should persist %20
+      expected: isWindows ? '/pathname%20with%20spaces.js' : '/pathname with spaces.js'
     },
     {
       url: '/test/windows.txt',
@@ -275,4 +278,18 @@ describe('GetFilenameFromUrl', () => {
       testUrl(test);
     });
   }
+
+  if (isWindows) {
+    // explicit test for #284
+    const test = {
+      url: '/test/windows.txt',
+      outputPath: 'C:\\My%20Path\\wwwroot',
+      publicPath: '/test',
+      expected: 'C://\\My%20Path\\wwwroot/windows.txt'
+    };
+
+    it(`windows: should process ${test.url} -> ${test.expected}`, () => {
+      testUrl(test);
+    });
+  }
 });