fixes #258: skip compilers with no publicPath (#259)

* fixes #258: skip compilers with no publicPath

* Add additional test, revert whitespace change

Author: threehams

lib/util.js

@@ -24,19 +24,21 @@ function getPaths(publicPath, compiler, url) {
     && compilers[i].options.output
     && compilers[i].options.output.publicPath;
 
-      if (compilerPublicPath.indexOf('/') === 0) {
-        compilerPublicPathBase = compilerPublicPath;
-      } else {
-        // handle the case where compilerPublicPath is a URL with hostname
-        compilerPublicPathBase = parse(compilerPublicPath).pathname;
-      }
+      if (compilerPublicPath) {
+        if (compilerPublicPath.indexOf('/') === 0) {
+          compilerPublicPathBase = compilerPublicPath;
+        } else {
+          // handle the case where compilerPublicPath is a URL with hostname
+          compilerPublicPathBase = parse(compilerPublicPath).pathname;
+        }
 
-      // check the url vs the path part of the compilerPublicPath
-      if (url.indexOf(compilerPublicPathBase) === 0) {
-        return {
-          publicPath: compilerPublicPath,
-          outputPath: compilers[i].outputPath
-        };
+        // check the url vs the path part of the compilerPublicPath
+        if (url.indexOf(compilerPublicPathBase) === 0) {
+          return {
+            publicPath: compilerPublicPath,
+            outputPath: compilers[i].outputPath
+          };
+        }
       }
     }
   }

test/fixtures/server-test/webpack.client.server.config.js

@@ -0,0 +1,18 @@
+'use strict';
+
+module.exports = [{
+  context: __dirname,
+  entry: './foo.js',
+  output: {
+    filename: 'foo.js',
+    path: '/client',
+    publicPath: '/static/'
+  }
+}, {
+  context: __dirname,
+  entry: './bar.js',
+  output: {
+    filename: 'bar.js',
+    path: '/server'
+  }
+}];

test/tests/server.js

@@ -9,6 +9,7 @@ const request = require('supertest');
 const middleware = require('../../');
 const webpackConfig = require('../fixtures/server-test/webpack.config');
 const webpackMultiConfig = require('../fixtures/server-test/webpack.array.config');
+const webpackClientServerConfig = require('../fixtures/server-test/webpack.client.server.config');
 
 describe('Server', () => {
   let instance;
@@ -245,6 +246,32 @@ describe('Server', () => {
     });
   });
 
+  describe('MultiCompiler: One `publicPath`', () => {
+    before((done) => {
+      app = express();
+      const compiler = webpack(webpackClientServerConfig);
+      instance = middleware(compiler, {
+        stats: 'errors-only',
+        logLevel: 'silent'
+      });
+      app.use(instance);
+      listen = listenShorthand(done);
+    });
+    after(close);
+
+    it('request to bundle file', (done) => {
+      request(app).get('/static/foo.js').expect(200, done);
+    });
+
+    it('request to nonexistent file', (done) => {
+      request(app).get('/static/invalid.js').expect(404, done);
+    });
+
+    it('request to non-public path', (done) => {
+      request(app).get('/').expect(404, done);
+    });
+  });
+
   describe('server side render', () => {
     let locals;
     before((done) => {