Use querystring.unescape to fallback to safer equivalent that does not throw on malformed URIs (#201)

Signed-off-by: petetnt <[email protected]>

Author: petetnt

lib/GetFilenameFromUrl.js

@@ -1,4 +1,5 @@
 var pathJoin = require("./PathJoin");
+var querystring = require("querystring");
 var urlParse = require("url").parse;
 
 function getFilenameFromUrl(publicPath, outputPath, url) {
@@ -29,8 +30,7 @@ function getFilenameFromUrl(publicPath, outputPath, url) {
 		return false;
 	}
 	// and if not match, use outputPath as filename
-	return decodeURIComponent(filename ? pathJoin(outputPath, filename) : outputPath);
-
+	return querystring.unescape(filename ? pathJoin(outputPath, filename) : outputPath);
 }
 
 // support for multi-compiler configuration

test/GetFilenameFromUrl.test.js

@@ -19,6 +19,11 @@ describe("GetFilenameFromUrl", function() {
 				outputPath: "/",
 				publicPath: "/",
 				expected: "/föö.js"
+			}, {
+				url: "/%foo%/%foo%.js", // Filenames can contain characters not allowed in URIs
+				outputPath: "/",
+				publicPath: "/",
+				expected: "/%foo%/%foo%.js"
 			}, {
 				url: "/0.19dc5d417382d73dd190.hot-update.js",
 				outputPath: "/",