Add linter and fix lint issues

Config copied from webpack-dev-server.

Author: SpaceK33z

.eslintrc

@@ -0,0 +1,25 @@
+{
+    "env": {
+        "node": true
+    },
+    "rules": {
+        "strict": 0,
+        "camelcase": 0,
+        "curly": 0,
+        "indent": [2, "tab"],
+        "eol-last": 2,
+        "no-shadow": 0,
+        "no-redeclare": 2,
+        "no-extra-bind": 2,
+        "no-empty": 0,
+        "no-process-exit": 2,
+        "no-underscore-dangle": 0,
+        "no-use-before-define": 0,
+        "no-unused-vars": 0,
+        "consistent-return": 0,
+        "no-inner-declarations": 2,
+        "no-loop-func": 2,
+        "no-undef": 2,
+        "space-before-function-paren": [2, "never"]
+    }
+}

.jsbeautifyrc

@@ -0,0 +1,25 @@
+{
+  "js": {
+    "allowed_file_extensions": ["js", "json", "jshintrc", "jsbeautifyrc"],
+    "brace_style": "collapse",
+    "break_chained_methods": false,
+    "e4x": true,
+    "eval_code": false,
+    "end_with_newline": true,
+    "indent_char": "\t",
+    "indent_level": 0,
+    "indent_size": 1,
+    "indent_with_tabs": true,
+    "jslint_happy": false,
+    "jslint_happy_align_switch_case": true,
+    "space_after_anon_function": false,
+    "keep_array_indentation": false,
+    "keep_function_indentation": false,
+    "max_preserve_newlines": 2,
+    "preserve_newlines": true,
+    "space_before_conditional": false,
+    "space_in_paren": false,
+    "unescape_strings": false,
+    "wrap_line_length": 0
+  }
+}

middleware.js

@@ -8,7 +8,7 @@ var parseRange = require("range-parser");
 
 var HASH_REGEXP = /[0-9a-f]{10,}/;
 
-var defaultReporter = function (reporterOptions) {
+var defaultReporter = function(reporterOptions) {
 	var state = reporterOptions.state;
 	var stats = reporterOptions.stats;
 	var options = reporterOptions.options;
@@ -60,12 +60,16 @@ module.exports = function(compiler, options) {
 		// We are now on valid state
 		state = true;
 		// Do the stuff in nextTick, because bundle may be invalidated
-		//  if a change happend while compiling
+		// if a change happened while compiling
 		process.nextTick(function() {
 			// check if still in valid state
 			if(!state) return;
 			// print webpack output
-			options.reporter({ state: true, stats: stats, options: options });
+			options.reporter({
+				state: true,
+				stats: stats,
+				options: options
+			});
 
 			// execute callback that are delayed
 			var cbs = callbacks;
@@ -85,10 +89,15 @@ module.exports = function(compiler, options) {
 	// on compiling
 	function invalidPlugin() {
 		if(state && (!options.noInfo && !options.quiet))
-			options.reporter({ state: false, options: options })
+			options.reporter({
+				state: false,
+				options: options
+			})
+
 		// We are now in invalid state
 		state = false;
 	}
+
 	function invalidAsyncPlugin(compiler, callback) {
 		invalidPlugin();
 		callback();
@@ -135,7 +144,7 @@ module.exports = function(compiler, options) {
 	}
 
 	function pathJoin(a, b) {
-		return a == "/" ? "/" + b : (a||"") + "/" + b
+		return a == "/" ? "/" + b : (a || "") + "/" + b
 	}
 
 	function getFilenameFromUrl(url) {
@@ -157,19 +166,19 @@ module.exports = function(compiler, options) {
 	}
 
 	function handleRangeHeaders(content, req, res) {
-		if (req.headers['Accept-Ranges']) res.setHeader('Accept-Ranges', 'bytes');
-		if (req.headers.range) {
+		if(req.headers['Accept-Ranges']) res.setHeader('Accept-Ranges', 'bytes');
+		if(req.headers.range) {
 			var ranges = parseRange(content.length, req.headers.range);
 
 			// unsatisfiable
-			if (-1 == ranges) {
+			if(-1 == ranges) {
 				res.setHeader('Content-Range', 'bytes */' + content.length);
 				res.statusCode = 416;
 				return content;
 			}
 
 			// valid (syntactically invalid/multiple ranges are treated as a regular response)
-			if (-2 != ranges && ranges.length === 1) {
+			if(-2 != ranges && ranges.length === 1) {
 				// Content-Range
 				res.statusCode = 206;
 				var length = content.length;
@@ -187,7 +196,7 @@ module.exports = function(compiler, options) {
 	// The middleware function
 	function webpackDevMiddleware(req, res, next) {
 		var filename = getFilenameFromUrl(req.url);
-		if (filename === false) return next();
+		if(filename === false) return next();
 
 		// in lazy mode, rebuild on bundle request
 		if(options.lazy && (!options.filename || options.filename.test(filename)))
@@ -203,11 +212,12 @@ module.exports = function(compiler, options) {
 		}
 		// delay the request until we have a vaild bundle
 		ready(processRequest, req);
+
 		function processRequest() {
 			try {
 				var stat = fs.statSync(filename);
 				if(!stat.isFile()) {
-					if (stat.isDirectory()) {
+					if(stat.isDirectory()) {
 						filename = pathJoin(filename, "index.html");
 						stat = fs.statSync(filename);
 						if(!stat.isFile()) throw "next";
@@ -231,21 +241,21 @@ module.exports = function(compiler, options) {
 				}
 			}
 			res.statusCode = 200;
-			if (res.send) res.send(content);
+			if(res.send) res.send(content);
 			else res.end(content);
 		}
 	}
 
 	webpackDevMiddleware.getFilenameFromUrl = getFilenameFromUrl;
 
 	webpackDevMiddleware.waitUntilValid = function(callback) {
-		callback = callback || function(){};
-		if (!watching || !watching.running) callback();
+		callback = callback || function() {};
+		if(!watching || !watching.running) callback();
 		else ready(callback, {});
 	};
 
 	webpackDevMiddleware.invalidate = function(callback) {
-		callback = callback || function(){};
+		callback = callback || function() {};
 		if(watching) {
 			ready(callback, {});
 			watching.invalidate();
@@ -255,7 +265,7 @@ module.exports = function(compiler, options) {
 	};
 
 	webpackDevMiddleware.close = function(callback) {
-		callback = callback || function(){};
+		callback = callback || function() {};
 		if(watching) watching.close(callback);
 		else callback();
 	};

package.json

@@ -11,6 +11,11 @@
     "mime": "^1.3.4",
     "range-parser": "^1.0.3"
   },
+  "devDependencies": {
+    "eslint": "^2.10.1",
+    "beautify-lint": "^1.0.4",
+    "js-beautify": "^1.6.3"
+  },
   "licenses": [
     {
       "type": "MIT",
@@ -25,5 +30,11 @@
   "repository": {
     "type": "git",
     "url": "https://github.com/webpack/webpack-dev-middleware.git"
+  },
+  "scripts": {
+    "lint": "eslint *.js",
+    "beautify-lint": "beautify-lint *.js",
+    "beautify": "beautify-rewrite *.js",
+    "travis": "npm run lint && npm run beautify-lint && node middleware.js"
   }
 }