Add more tests

Author: SpaceK33z

lib/GetFilenameFromUrl.js

@@ -10,7 +10,7 @@ function getFilenameFromUrl(publicPath, outputPath, url) {
 
 	// publicPath has the hostname that is not the same as request url's, should fail
 	if(localPrefix.hostname !== null && urlObject.hostname !== null &&
-		   localPrefix.hostname !== urlObject.hostname) {
+		localPrefix.hostname !== urlObject.hostname) {
 		return false;
 	}
 
@@ -25,7 +25,7 @@ function getFilenameFromUrl(publicPath, outputPath, url) {
 	}
 
 	if(!urlObject.hostname && localPrefix.hostname &&
-	   url.indexOf(localPrefix.path) !== 0) {
+		url.indexOf(localPrefix.path) !== 0) {
 		return false;
 	}
 	// and if not match, use outputPath as filename

test/Lazy.test.js

@@ -0,0 +1,87 @@
+var should = require("should");
+var middleware = require("../middleware");
+
+var doneStats = {
+	hasErrors: function() {
+		return false;
+	},
+	hasWarnings: function() {
+		return false;
+	}
+};
+
+describe("Lazy mode", function() {
+	var compiler = {
+		plugin: function(name, callback) {
+			plugins[name] = callback;
+		}
+	};
+	var instance;
+	var next;
+	var res = {};
+
+	var plugins = [];
+	beforeEach(function() {
+		plugins = {};
+		compiler.run = this.sinon.stub();
+		next = this.sinon.stub();
+	});
+
+	describe("builds", function() {
+		var req = { method: "GET", url: "/bundle.js" };
+		beforeEach(function() {
+			instance = middleware(compiler, { lazy: true, quiet: true });
+		});
+		it("should trigger build", function(done) {
+			instance(req, res, next);
+			should.strictEqual(compiler.run.callCount, 1);
+			plugins.done(doneStats);
+			setTimeout(function() {
+				should.strictEqual(next.callCount, 1);
+				done();
+			});
+		});
+
+		it("should trigger rebuild when state is invalidated", function(done) {
+			plugins.invalid();
+			instance(req, res, next);
+			plugins.done(doneStats);
+
+			should.strictEqual(compiler.run.callCount, 1);
+			setTimeout(function() {
+				should.strictEqual(next.callCount, 0);
+				done();
+			});
+		});
+
+		it("should pass through compiler error", function() {
+			compiler.run.callsArgWith(0, new Error("MyCompilerError"));
+			should.throws(function() {
+				instance(req, res, next);
+			}, "MyCompilerError");
+		});
+	});
+
+	describe("custom filename", function() {
+		it("should trigger build", function() {
+			instance = middleware(compiler, { lazy: true, quiet: true, filename: "foo.js" });
+
+			var req = { method: "GET", url: "/bundle.js" };
+			instance(req, res, next);
+			should.strictEqual(compiler.run.callCount, 0);
+
+			req = { method: "GET", url: "/foo.js" };
+			instance(req, res, next);
+			should.strictEqual(compiler.run.callCount, 1);
+		});
+
+		it("should allow prepended slash", function() {
+			var options = { lazy: true, quiet: true, filename: "/foo.js" };
+			instance = middleware(compiler, options);
+
+			var req = { method: "GET", url: "/foo.js" };
+			instance(req, res, next);
+			should.strictEqual(compiler.run.callCount, 1);
+		});
+	});
+});

test/Server.test.js

@@ -29,12 +29,15 @@ describe("Server", function() {
 		before(function(done) {
 			app = express();
 			var compiler = webpack(webpackConfig);
-			app.use(middleware(compiler, {
+			var instance = middleware(compiler, {
 				stats: "errors-only",
 				quiet: true,
 				publicPath: "/",
-			}));
+			});
+			app.use(instance);
 			listen = listenShorthand(done);
+			// Hack to add a mock HMR json file to the in-memory filesystem.
+			instance.fileSystem.writeFileSync("/123a123412.hot-update.json", "[\"hi\"]");
 		});
 		after(close);
 
@@ -65,6 +68,12 @@ describe("Server", function() {
 			.expect(404, done);
 		});
 
+		it("request to HMR json", function(done) {
+			request(app).get("/123a123412.hot-update.json")
+			.expect("Content-Type", "application/json")
+			.expect(200, /\[\"hi\"\]/, done);
+		});
+
 		it("request to directory", function(done) {
 			request(app).get("/")
 			.expect("Content-Type", "text/html")