Skip to content

Commit 39807da

Browse files
authored
test: disable to output logs (#2109)
1 parent 5f64974 commit 39807da

12 files changed

+80
-13
lines changed

test/client/clients/SockJSClient.test.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,13 @@ const SockJSClient = require('../../../client-src/clients/SockJSClient');
77
const port = require('../../ports-map').sockJSClient;
88

99
describe('SockJSClient', () => {
10+
let consoleMock;
1011
let socketServer;
1112
let listeningApp;
1213

1314
beforeAll((done) => {
15+
consoleMock = jest.spyOn(console, 'log').mockImplementation();
16+
1417
// eslint-disable-next-line new-cap
1518
const app = new express();
1619

@@ -24,6 +27,10 @@ describe('SockJSClient', () => {
2427
});
2528
});
2629

30+
afterAll(() => {
31+
consoleMock.mockRestore();
32+
});
33+
2734
describe('client', () => {
2835
it('should open, receive message, and close', (done) => {
2936
socketServer.on('connection', (connection) => {

test/e2e/ClientOptions.test.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ describe('Client code', () => {
3333
watchOptions: {
3434
poll: true,
3535
},
36+
quiet: true,
3637
};
3738
testServer.startAwaitingCompilation(config, options, done);
3839
});
@@ -95,6 +96,7 @@ describe('Client complex inline script path', () => {
9596
},
9697
public: 'myhost.test',
9798
sockPath: '/foo/test/bar/',
99+
quiet: true,
98100
};
99101
testServer.startAwaitingCompilation(config, options, done);
100102
});
@@ -135,6 +137,7 @@ describe('Client complex inline script path with sockPort', () => {
135137
},
136138
sockPath: '/foo/test/bar/',
137139
sockPort: port3,
140+
quiet: true,
138141
};
139142
testServer.startAwaitingCompilation(config, options, done);
140143
});
@@ -178,6 +181,7 @@ describe('Client complex inline script path with sockPort, no sockPath', () => {
178181
poll: true,
179182
},
180183
sockPort: port3,
184+
quiet: true,
181185
};
182186
testServer.startAwaitingCompilation(config, options, done);
183187
});
@@ -215,6 +219,7 @@ describe('Client complex inline script path with sockHost', () => {
215219
poll: true,
216220
},
217221
sockHost: 'myhost.test',
222+
quiet: true,
218223
};
219224
testServer.startAwaitingCompilation(config, options, done);
220225
});
@@ -246,6 +251,7 @@ describe('Client console.log', () => {
246251
const baseOptions = {
247252
port: port2,
248253
host: '0.0.0.0',
254+
quiet: true,
249255
};
250256
const cases = [
251257
{

test/e2e/Progress.test.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,31 @@
55
*/
66
const fs = require('fs');
77
const { resolve } = require('path');
8-
const testServer = require('../helpers/test-server');
98
const reloadConfig = require('../fixtures/reload-config/webpack.config');
109
const runBrowser = require('../helpers/run-browser');
1110
const port = require('../ports-map').Progress;
1211

1312
const cssFilePath = resolve(__dirname, '../fixtures/reload-config/main.css');
1413

1514
describe('client progress', () => {
15+
let testServer;
16+
let processStderrMock;
17+
1618
describe('using hot', () => {
1719
beforeAll((done) => {
20+
// ProgressPlugin uses process.stderr and reset webpack
21+
jest.resetModules();
22+
processStderrMock = jest
23+
.spyOn(process.stderr, 'write')
24+
.mockImplementation();
25+
// eslint-disable-next-line global-require
26+
testServer = require('../helpers/test-server');
27+
1828
fs.writeFileSync(
1929
cssFilePath,
2030
'body { background-color: rgb(0, 0, 255); }'
2131
);
32+
2233
const options = {
2334
port,
2435
host: '0.0.0.0',
@@ -29,12 +40,14 @@ describe('client progress', () => {
2940
poll: 500,
3041
},
3142
};
43+
3244
testServer.startAwaitingCompilation(reloadConfig, options, done);
3345
});
3446

3547
afterAll((done) => {
3648
fs.unlinkSync(cssFilePath);
3749
testServer.close(done);
50+
processStderrMock.mockRestore();
3851
});
3952

4053
describe('on browser client', () => {

test/helpers/test-server.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
/* eslint-disable
44
no-undefined
55
*/
6+
67
const webpack = require('webpack');
78
const Server = require('../../lib/Server');
89

test/options.test.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,16 @@ const config = require('./fixtures/simple-config/webpack.config');
1212
describe('options', () => {
1313
jest.setTimeout(20000);
1414

15+
let consoleMock;
16+
17+
beforeAll(() => {
18+
consoleMock = jest.spyOn(console, 'warn').mockImplementation();
19+
});
20+
21+
afterAll(() => {
22+
consoleMock.mockRestore();
23+
});
24+
1525
it('should match properties and errorMessage', () => {
1626
const properties = Object.keys(options.properties);
1727
const messages = Object.keys(options.errorMessage.properties);

test/server/Server.test.js

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ const port = require('../ports-map').Server;
1010

1111
jest.mock('sockjs/lib/transport');
1212

13+
const baseDevConfig = {
14+
port,
15+
quiet: true,
16+
};
17+
1318
describe('Server', () => {
1419
describe('sockjs', () => {
1520
it('add decorateConnection', () => {
@@ -22,10 +27,12 @@ describe('Server', () => {
2227
describe('addEntries', () => {
2328
it('add hot option', (done) => {
2429
const compiler = webpack(config);
25-
const server = new Server(compiler, {
26-
hot: true,
27-
port,
28-
});
30+
const server = new Server(
31+
compiler,
32+
Object.assign({}, baseDevConfig, {
33+
hot: true,
34+
})
35+
);
2936

3037
expect(
3138
server.middleware.context.compiler.options.entry.map((p) => {
@@ -45,10 +52,12 @@ describe('Server', () => {
4552

4653
it('add hotOnly option', (done) => {
4754
const compiler = webpack(config);
48-
const server = new Server(compiler, {
49-
hotOnly: true,
50-
port,
51-
});
55+
const server = new Server(
56+
compiler,
57+
Object.assign({}, baseDevConfig, {
58+
hotOnly: true,
59+
})
60+
);
5261

5362
expect(
5463
server.middleware.context.compiler.options.entry.map((p) => {
@@ -95,7 +104,7 @@ describe('Server', () => {
95104
});
96105

97106
const compiler = webpack(config);
98-
const server = new Server(compiler, { port });
107+
const server = new Server(compiler, baseDevConfig);
99108

100109
compiler.hooks.done.tap('webpack-dev-server', (s) => {
101110
const output = server.getStats(s);
@@ -139,7 +148,7 @@ describe('Server', () => {
139148
describe('Testing callback functions on calling invalidate without callback', () => {
140149
it('should be `noop` (the default callback function)', (done) => {
141150
const compiler = webpack(config);
142-
const server = new Server(compiler, { port });
151+
const server = new Server(compiler, baseDevConfig);
143152

144153
server.invalidate();
145154
expect(server.middleware.context.callbacks[0]).toBe(noop);
@@ -156,7 +165,7 @@ describe('Server', () => {
156165
it('should be `callback` function', (done) => {
157166
const compiler = webpack(config);
158167
const callback = jest.fn();
159-
const server = new Server(compiler, { port });
168+
const server = new Server(compiler, baseDevConfig);
160169

161170
server.invalidate(callback);
162171

test/server/open-option.test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ describe('open option', () => {
2020
const server = new Server(compiler, {
2121
open: true,
2222
port,
23+
quiet: true,
2324
});
2425

2526
compiler.hooks.done.tap('webpack-dev-server', () => {

test/server/profile-option.test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ describe('profile', () => {
2222
// profile will only have an effect when progress is enabled
2323
progress: true,
2424
profile: true,
25+
quiet: true,
2526
});
2627

2728
compiler.hooks.done.tap('webpack-dev-server', () => {

test/server/progress-option.test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ describe('progress', () => {
2020
const server = new Server(compiler, {
2121
port,
2222
progress: true,
23+
quiet: true,
2324
});
2425

2526
compiler.hooks.done.tap('webpack-dev-server', () => {

test/server/serverMode-option.test.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ describe('serverMode option', () => {
1717
let server;
1818
let req;
1919
let getSocketServerImplementation;
20+
let consoleMock;
2021

2122
const serverModes = [
2223
{
@@ -45,6 +46,14 @@ describe('serverMode option', () => {
4546
},
4647
];
4748

49+
beforeAll(() => {
50+
consoleMock = jest.spyOn(console, 'log').mockImplementation();
51+
});
52+
53+
afterAll(() => {
54+
consoleMock.mockRestore();
55+
});
56+
4857
describe('is passed to getSocketServerImplementation correctly', () => {
4958
beforeEach(() => {
5059
jest.mock('../../lib/utils/getSocketServerImplementation');

0 commit comments

Comments
 (0)