Skip to content

Commit 3a247fb

Browse files
snitin315alexander-akait
snitin315
authored and
alexander-akait
committed
test: fix flaky overlay E2E tests (#4929)
1 parent 7a2b006 commit 3a247fb

File tree

1 file changed

+86
-0
lines changed

1 file changed

+86
-0
lines changed

‎test/e2e/overlay.test.js

Lines changed: 86 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ class WarningPlugin {
6464
}
6565
}
6666

67+
const delay = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
68+
6769
describe("overlay", () => {
6870
it("should show a warning for initial compilation", async () => {
6971
const compiler = webpack(config);
@@ -83,6 +85,9 @@ describe("overlay", () => {
8385
waitUntil: "networkidle0",
8486
});
8587

88+
// Delay for the overlay to appear
89+
await delay(1000);
90+
8691
const pageHtml = await page.evaluate(() => document.body.outerHTML);
8792
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
8893
const overlayFrame = await overlayHandle.contentFrame();
@@ -120,6 +125,9 @@ describe("overlay", () => {
120125
waitUntil: "networkidle0",
121126
});
122127

128+
// Delay for the overlay to appear
129+
await delay(1000);
130+
123131
const pageHtml = await page.evaluate(() => document.body.outerHTML);
124132
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
125133
const overlayFrame = await overlayHandle.contentFrame();
@@ -164,6 +172,9 @@ describe("overlay", () => {
164172
waitUntil: "networkidle0",
165173
});
166174

175+
// Delay for the overlay to appear
176+
await delay(1000);
177+
167178
const pageHtml = await page.evaluate(() => document.body.outerHTML);
168179
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
169180
const overlayFrame = await overlayHandle.contentFrame();
@@ -206,6 +217,9 @@ describe("overlay", () => {
206217
waitUntil: "networkidle0",
207218
});
208219

220+
// Delay for the overlay to appear
221+
await delay(1000);
222+
209223
const pageHtml = await page.evaluate(() => document.body.outerHTML);
210224
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
211225
const overlayFrame = await overlayHandle.contentFrame();
@@ -247,6 +261,9 @@ describe("overlay", () => {
247261
waitUntil: "networkidle0",
248262
});
249263

264+
// Delay for the overlay to appear
265+
await delay(1000);
266+
250267
const pageHtml = await page.evaluate(() => document.body.outerHTML);
251268
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
252269
const overlayFrame = await overlayHandle.contentFrame();
@@ -578,6 +595,9 @@ describe("overlay", () => {
578595
waitUntil: "networkidle0",
579596
});
580597

598+
// Delay for the overlay to appear
599+
await delay(1000);
600+
581601
const pageHtml = await page.evaluate(() => document.body.outerHTML);
582602
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
583603

@@ -617,6 +637,9 @@ describe("overlay", () => {
617637
waitUntil: "networkidle0",
618638
});
619639

640+
// Delay for the overlay to appear
641+
await delay(1000);
642+
620643
const pageHtml = await page.evaluate(() => document.body.outerHTML);
621644
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
622645

@@ -662,6 +685,9 @@ describe("overlay", () => {
662685
waitUntil: "networkidle0",
663686
});
664687

688+
// Delay for the overlay to appear
689+
await delay(1000);
690+
665691
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
666692

667693
expect(overlayHandle).toBe(null);
@@ -699,6 +725,9 @@ describe("overlay", () => {
699725
waitUntil: "networkidle0",
700726
});
701727

728+
// Delay for the overlay to appear
729+
await delay(1000);
730+
702731
const pageHtml = await page.evaluate(() => document.body.outerHTML);
703732
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
704733
const overlayFrame = await overlayHandle.contentFrame();
@@ -742,6 +771,9 @@ describe("overlay", () => {
742771
waitUntil: "networkidle0",
743772
});
744773

774+
// Delay for the overlay to appear
775+
await delay(1000);
776+
745777
const pageHtml = await page.evaluate(() => document.body.outerHTML);
746778
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
747779
const overlayFrame = await overlayHandle.contentFrame();
@@ -787,6 +819,9 @@ describe("overlay", () => {
787819
waitUntil: "networkidle0",
788820
});
789821

822+
// Delay for the overlay to appear
823+
await delay(1000);
824+
790825
const pageHtml = await page.evaluate(() => document.body.outerHTML);
791826
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
792827
const overlayFrame = await overlayHandle.contentFrame();
@@ -832,6 +867,9 @@ describe("overlay", () => {
832867
waitUntil: "networkidle0",
833868
});
834869

870+
// Delay for the overlay to appear
871+
await delay(1000);
872+
835873
const pageHtml = await page.evaluate(() => document.body.outerHTML);
836874
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
837875
const overlayFrame = await overlayHandle.contentFrame();
@@ -875,6 +913,9 @@ describe("overlay", () => {
875913
waitUntil: "networkidle0",
876914
});
877915

916+
// Delay for the overlay to appear
917+
await delay(1000);
918+
878919
const pageHtml = await page.evaluate(() => document.body.outerHTML);
879920
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
880921

@@ -914,6 +955,9 @@ describe("overlay", () => {
914955
waitUntil: "networkidle0",
915956
});
916957

958+
// Delay for the overlay to appear
959+
await delay(1000);
960+
917961
const pageHtml = await page.evaluate(() => document.body.outerHTML);
918962
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
919963

@@ -960,6 +1004,9 @@ describe("overlay", () => {
9601004
waitUntil: "networkidle0",
9611005
});
9621006

1007+
// Delay for the overlay to appear
1008+
await delay(1000);
1009+
9631010
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
9641011

9651012
expect(overlayHandle).toBe(null);
@@ -997,6 +1044,9 @@ describe("overlay", () => {
9971044
waitUntil: "networkidle0",
9981045
});
9991046

1047+
// Delay for the overlay to appear
1048+
await delay(1000);
1049+
10001050
const pageHtml = await page.evaluate(() => document.body.outerHTML);
10011051
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
10021052
const overlayFrame = await overlayHandle.contentFrame();
@@ -1040,6 +1090,9 @@ describe("overlay", () => {
10401090
waitUntil: "networkidle0",
10411091
});
10421092

1093+
// Delay for the overlay to appear
1094+
await delay(1000);
1095+
10431096
const pageHtml = await page.evaluate(() => document.body.outerHTML);
10441097
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
10451098
const overlayFrame = await overlayHandle.contentFrame();
@@ -1085,6 +1138,9 @@ describe("overlay", () => {
10851138
waitUntil: "networkidle0",
10861139
});
10871140

1141+
// Delay for the overlay to appear
1142+
await delay(1000);
1143+
10881144
const pageHtml = await page.evaluate(() => document.body.outerHTML);
10891145
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
10901146
const overlayFrame = await overlayHandle.contentFrame();
@@ -1130,6 +1186,9 @@ describe("overlay", () => {
11301186
waitUntil: "networkidle0",
11311187
});
11321188

1189+
// Delay for the overlay to appear
1190+
await delay(1000);
1191+
11331192
const pageHtml = await page.evaluate(() => document.body.outerHTML);
11341193
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
11351194
expect(overlayHandle).toBe(null);
@@ -1168,6 +1227,9 @@ describe("overlay", () => {
11681227
waitUntil: "networkidle0",
11691228
});
11701229

1230+
// Delay for the overlay to appear
1231+
await delay(1000);
1232+
11711233
const pageHtml = await page.evaluate(() => document.body.outerHTML);
11721234
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
11731235
const overlayFrame = await overlayHandle.contentFrame();
@@ -1213,6 +1275,9 @@ describe("overlay", () => {
12131275
waitUntil: "networkidle0",
12141276
});
12151277

1278+
// Delay for the overlay to appear
1279+
await delay(1000);
1280+
12161281
const pageHtml = await page.evaluate(() => document.body.outerHTML);
12171282
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
12181283
const overlayFrame = await overlayHandle.contentFrame();
@@ -1257,6 +1322,9 @@ describe("overlay", () => {
12571322
waitUntil: "networkidle0",
12581323
});
12591324

1325+
// Delay for the overlay to appear
1326+
await delay(1000);
1327+
12601328
const pageHtml = await page.evaluate(() => document.body.outerHTML);
12611329
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
12621330
const overlayFrame = await overlayHandle.contentFrame();
@@ -1328,6 +1396,9 @@ describe("overlay", () => {
13281396
});
13291397
});
13301398

1399+
// Delay for the overlay to appear
1400+
await delay(1000);
1401+
13311402
await page.waitForSelector("#webpack-dev-server-client-overlay");
13321403

13331404
const pageHtml = await page.evaluate(() => document.body.outerHTML);
@@ -1382,6 +1453,9 @@ describe("overlay", () => {
13821453
});
13831454
});
13841455

1456+
// Delay for the overlay to appear
1457+
await delay(1000);
1458+
13851459
await page.waitForSelector("#webpack-dev-server-client-overlay");
13861460

13871461
const pageHtml = await page.evaluate(() => document.body.outerHTML);
@@ -1430,6 +1504,9 @@ describe("overlay", () => {
14301504
})();`,
14311505
});
14321506

1507+
// Delay for the overlay to appear
1508+
await delay(1000);
1509+
14331510
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
14341511
const overlayFrame = await overlayHandle.contentFrame();
14351512
const overlayHtml = await overlayFrame.evaluate(
@@ -1477,6 +1554,9 @@ describe("overlay", () => {
14771554
})();`,
14781555
});
14791556

1557+
// Delay for the overlay to appear
1558+
await delay(1000);
1559+
14801560
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
14811561

14821562
expect(overlayHandle).toBe(null);
@@ -1515,6 +1595,9 @@ describe("overlay", () => {
15151595
})();`,
15161596
});
15171597

1598+
// Delay for the overlay to appear
1599+
await delay(1000);
1600+
15181601
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
15191602
const overlayFrame = await overlayHandle.contentFrame();
15201603
const overlayHtml = await overlayFrame.evaluate(
@@ -1564,6 +1647,9 @@ describe("overlay", () => {
15641647
})();`,
15651648
});
15661649

1650+
// Delay for the overlay to appear
1651+
await delay(1000);
1652+
15671653
const overlayHandle = await page.$("#webpack-dev-server-client-overlay");
15681654

15691655
expect(overlayHandle).toBe(null);

0 commit comments

Comments
 (0)