test: refactor web socket server tests to cleanup properly (#4921)

Author: snitin315

test/e2e/web-socket-server.test.js

@@ -21,36 +21,40 @@ describe("web socket server", () => {
 
     const { page, browser } = await runBrowser();
 
-    const pageErrors = [];
-    const consoleMessages = [];
-
-    page
-      .on("console", (message) => {
-        consoleMessages.push(message);
-      })
-      .on("pageerror", (error) => {
-        pageErrors.push(error);
-      });
+    try {
+      const pageErrors = [];
+      const consoleMessages = [];
 
-    const webSocketRequests = [];
+      page
+        .on("console", (message) => {
+          consoleMessages.push(message);
+        })
+        .on("pageerror", (error) => {
+          pageErrors.push(error);
+        });
 
-    const client = page._client;
+      const webSocketRequests = [];
 
-    client.on("Network.webSocketCreated", (test) => {
-      webSocketRequests.push(test);
-    });
+      const client = page._client;
 
-    await page.goto(`http://127.0.0.1:${port}/`, {
-      waitUntil: "networkidle0",
-    });
+      client.on("Network.webSocketCreated", (test) => {
+        webSocketRequests.push(test);
+      });
 
-    expect(webSocketRequests).toHaveLength(0);
-    expect(consoleMessages.map((message) => message.text())).toMatchSnapshot(
-      "console messages"
-    );
-    expect(pageErrors).toMatchSnapshot("page errors");
+      await page.goto(`http://127.0.0.1:${port}/`, {
+        waitUntil: "networkidle0",
+      });
 
-    await browser.close();
-    await server.stop();
+      expect(webSocketRequests).toHaveLength(0);
+      expect(consoleMessages.map((message) => message.text())).toMatchSnapshot(
+        "console messages"
+      );
+      expect(pageErrors).toMatchSnapshot("page errors");
+    } catch (error) {
+      throw error;
+    } finally {
+      await browser.close();
+      await server.stop();
+    }
   });
 });