CLI finds and uses 1st available port when none specified. (#685)

Author: benwiley4000

bin/webpack-dev-server.js

@@ -5,6 +5,7 @@ var open = require("opn");
 var fs = require("fs");
 var net = require("net");
 var url = require("url");
+var portfinder = require("portfinder");
 
 // Local version replaces global one
 try {
@@ -46,6 +47,11 @@ var CONNECTION_GROUP = "Connection options:";
 var RESPONSE_GROUP = "Response options:";
 var BASIC_GROUP = "Basic options:";
 
+// Taken out of yargs because we must know if
+// it wasn't given by the user, in which case
+// we should use portfinder.
+var DEFAULT_PORT = 8080;
+
 yargs.options({
 	"lazy": {
 		type: "boolean",
@@ -143,7 +149,6 @@ yargs.options({
 	},
 	"port": {
 		describe: "The port",
-		default: 8080,
 		group: CONNECTION_GROUP
 	},
 	"socket": {
@@ -190,9 +195,6 @@ function processOptions(wpOpt) {
 	if(argv.public)
 		options.public = argv.public;
 
-	if(argv.port !== 8080 || !options.port)
-		options.port = argv.port;
-
 	if(argv.socket)
 		options.socket = argv.socket;
 
@@ -291,6 +293,25 @@ function processOptions(wpOpt) {
 	if(argv["open"])
 		options.open = true;
 
+	// Kind of weird, but ensures prior behavior isn't broken in cases
+	// that wouldn't throw errors. E.g. both argv.port and options.port
+	// were specified, but since argv.port is 8080, options.port will be
+	// tried first instead.
+	options.port = argv.port === DEFAULT_PORT ? (options.port || argv.port) : (argv.port || options.port);
+	if(options.port) {
+		startDevServer(wpOpt, options);
+		return;
+	}
+
+	portfinder.basePort = DEFAULT_PORT;
+	portfinder.getPort(function(err, port) {
+		if(err) throw err;
+		options.port = port;
+		startDevServer(wpOpt, options);
+	});
+}
+
+function startDevServer(wpOpt, options) {
 	var protocol = options.https ? "https" : "http";
 
 	// the formatted domain (url without path) of the webpack server

package.json

@@ -13,6 +13,7 @@
     "express": "^4.13.3",
     "http-proxy-middleware": "~0.17.1",
     "opn": "4.0.2",
+    "portfinder": "^1.0.9",
     "serve-index": "^1.7.2",
     "sockjs": "0.3.18",
     "sockjs-client": "1.1.1",