refactor(eslint): make global-require to off (#2137)

Author: hiroppy

.eslintrc

@@ -15,6 +15,7 @@
     "no-underscore-dangle": "off",
     "prefer-destructuring": ["error", { "object": false, "array": false }],
     "prefer-rest-params": "off",
-    "strict": ["error", "safe"]
+    "strict": ["error", "safe"],
+    "global-require": "off"
   }
 }

bin/options.js

@@ -1,7 +1,6 @@
 'use strict';
 
 /* eslint-disable
-  global-require,
   multiline-ternary,
   space-before-function-paren
 */

client-src/default/utils/reloadApp.js

@@ -13,7 +13,6 @@ function reloadApp(
   }
   if (hot) {
     log.info('[WDS] App hot update...');
-    // eslint-disable-next-line global-require
     const hotEmitter = require('webpack/hot/emitter');
     hotEmitter.emit('webpackHotUpdate', currentHash);
     if (typeof self !== 'undefined' && self.window) {

client-src/live/index.js

@@ -1,6 +1,6 @@
 'use strict';
 
-/* eslint import/no-extraneous-dependencies: off, global-require: off */
+/* eslint import/no-extraneous-dependencies: off */
 
 const $ = require('jquery');
 const stripAnsi = require('strip-ansi');

examples/general/proxy-hot-reload/webpack.config.js

@@ -1,6 +1,5 @@
 'use strict';
 
-/* eslint global-require: off */
 const fs = require('fs');
 // our setup function adds behind-the-scenes bits to the config that all of our
 // examples need

lib/Server.js

@@ -665,7 +665,6 @@ class Server {
         // The relevant issues are:
         // https://github.com/spdy-http2/node-spdy/issues/350
         // https://github.com/webpack/webpack-dev-server/issues/1592
-        // eslint-disable-next-line global-require
         this.listeningApp = require('spdy').createServer(
           this.options.https,
           this.app

lib/servers/SockJSServer.js

@@ -11,7 +11,6 @@ const BaseServer = require('./BaseServer');
 // sockjs will remove Origin header, however Origin header is required for checking host.
 // See https://github.com/webpack/webpack-dev-server/issues/1604 for more information
 {
-  // eslint-disable-next-line global-require
   const SockjsSession = require('sockjs/lib/transport').Session;
   const decorateConnection = SockjsSession.prototype.decorateConnection;
   SockjsSession.prototype.decorateConnection = function(req) {

lib/utils/getSocketClientPath.js

@@ -7,14 +7,12 @@ function getSocketClientPath(options) {
     case 'string':
       // could be 'sockjs', 'ws', or a path that should be required
       if (options.clientMode === 'sockjs') {
-        // eslint-disable-next-line global-require
         ClientImplementation = require('../../client/clients/SockJSClient');
       } else if (options.clientMode === 'ws') {
-        // eslint-disable-next-line global-require
         ClientImplementation = require('../../client/clients/WebsocketClient');
       } else {
         try {
-          // eslint-disable-next-line global-require, import/no-dynamic-require
+          // eslint-disable-next-line import/no-dynamic-require
           ClientImplementation = require(options.clientMode);
         } catch (e) {
           clientImplFound = false;

lib/utils/getSocketServerImplementation.js

@@ -7,14 +7,12 @@ function getSocketServerImplementation(options) {
     case 'string':
       // could be 'sockjs', in the future 'ws', or a path that should be required
       if (options.serverMode === 'sockjs') {
-        // eslint-disable-next-line global-require
         ServerImplementation = require('../servers/SockJSServer');
       } else if (options.serverMode === 'ws') {
-        // eslint-disable-next-line global-require
         ServerImplementation = require('../servers/WebsocketServer');
       } else {
         try {
-          // eslint-disable-next-line global-require, import/no-dynamic-require
+          // eslint-disable-next-line import/no-dynamic-require
           ServerImplementation = require(options.serverMode);
         } catch (e) {
           serverImplFound = false;

lib/utils/getVersions.js

@@ -1,7 +1,5 @@
 'use strict';
 
-/* eslint-disable global-require */
-
 function getVersions() {
   return (
     `webpack-dev-server ${require('../../package.json').version}\n` +