Add extra eslint rules

Author: SpaceK33z

.eslintrc

@@ -6,6 +6,7 @@
 	"rules": {
 		"indent": [2, "tab", { "SwitchCase": 1 }],
 		"brace-style": ["error", "1tbs"],
+		"quotes": ["error", "double"],
 		"no-eval": "error",
 		"eol-last": "error",
 		"no-redeclare": "error",
@@ -22,6 +23,8 @@
 		"no-unused-vars": "error",
 		"no-dupe-keys": "error",
 		"valid-typeof": "error",
+		"object-curly-spacing": ["error", "always"],
+		"key-spacing": "error",
 		"space-infix-ops": "error",
 		"no-negated-in-lhs": "error",
 		"no-octal": "error",
@@ -38,6 +41,7 @@
 			"overrides": {
 				"try": {"after": true},
 				"else": {"after": true},
+				"throw": {"after": true},
 				"case": {"after": true},
 				"return": {"after": true},
 				"finally": {"after": true},

bin/webpack-dev-server.js

@@ -165,7 +165,7 @@ function processOptions(wpOpt) {
 		options.watchOptions = firstWpOpt.watchOptions;
 
 	if(argv["stdin"]) {
-		process.stdin.on('end', function() {
+		process.stdin.on("end", function() {
 			process.exit(0); // eslint-disable-line no-process-exit
 		});
 		process.stdin.resume();

client/index.js

@@ -1,7 +1,7 @@
 /* global __resourceQuery */
-var url = require('url');
-var stripAnsi = require('strip-ansi');
-var socket = require('./socket');
+var url = require("url");
+var stripAnsi = require("strip-ansi");
+var socket = require("./socket");
 
 function getCurrentScriptSource() {
 	// `document.currentScript` is the most accurate way to find the current script,
@@ -91,11 +91,11 @@ var onSocketMsg = {
 var hostname = urlParts.hostname;
 var protocol = urlParts.protocol;
 
-if(urlParts.hostname === '0.0.0.0') {
+if(urlParts.hostname === "0.0.0.0") {
 	// why do we need this check?
 	// hostname n/a for file protocol (example, when using electron, ionic)
 	// see: https://github.com/webpack/webpack-dev-server/pull/384
-	if(window.location.hostname && !!~window.location.protocol.indexOf('http')) {
+	if(window.location.hostname && !!~window.location.protocol.indexOf("http")) {
 		hostname = window.location.hostname;
 	}
 }
@@ -104,16 +104,16 @@ if(urlParts.hostname === '0.0.0.0') {
 // a protocol would result in an invalid URL.
 // When https is used in the app, secure websockets are always necessary
 // because the browser doesn't accept non-secure websockets.
-if(hostname && (window.location.protocol === "https:" || urlParts.hostname === '0.0.0.0')) {
+if(hostname && (window.location.protocol === "https:" || urlParts.hostname === "0.0.0.0")) {
 	protocol = window.location.protocol;
 }
 
 var socketUrl = url.format({
 	protocol: protocol,
 	auth: urlParts.auth,
 	hostname: hostname,
-	port: (urlParts.port === '0') ? window.location.port : urlParts.port,
-	pathname: urlParts.path == null || urlParts.path === '/' ? "/sockjs-node" : urlParts.path
+	port: (urlParts.port === "0") ? window.location.port : urlParts.port,
+	pathname: urlParts.path == null || urlParts.path === "/" ? "/sockjs-node" : urlParts.path
 });
 
 socket(socketUrl, onSocketMsg);

client/live.js

@@ -1,6 +1,6 @@
 var $ = require("jquery");
-var stripAnsi = require('strip-ansi');
-var socket = require('./socket');
+var stripAnsi = require("strip-ansi");
+var socket = require("./socket");
 require("./style.css");
 
 var hot = false;

client/sockjs.js

@@ -1 +1 @@
-module.exports = require('sockjs-client');
+module.exports = require("sockjs-client");

examples/node-api-middleware/server.js

@@ -1,4 +1,4 @@
-var Webpack = require('webpack');
+var Webpack = require("webpack");
 var WebpackDevServer = require("../../lib/Server");
 var webpackConfig = require("./webpack.config");
 

examples/node-api-simple/server.js

@@ -1,4 +1,4 @@
-var Webpack = require('webpack');
+var Webpack = require("webpack");
 var WebpackDevServer = require("../../lib/Server");
 var webpackConfig = require("./webpack.config");
 

examples/proxy-advanced/webpack.config.js

@@ -3,15 +3,15 @@ module.exports = {
 	entry: "./app.js",
 	devServer: {
 		proxy: {
-			'/api': {
-				target: 'http://jsonplaceholder.typicode.com/',
+			"/api": {
+				target: "http://jsonplaceholder.typicode.com/",
 				changeOrigin: true,
 				pathRewrite: {
-					'^/api': ''
+					"^/api": ""
 				},
 				bypass: function(req) {
-					if(req.url === '/api/nope') {
-						return '/bypass.html';
+					if(req.url === "/api/nope") {
+						return "/bypass.html";
 					}
 				}
 			}

examples/proxy-hot-reload/proxy-config.js

@@ -1,8 +1,8 @@
 /**/
 module.exports = {
-	target: 'http://jsonplaceholder.typicode.com/',
+	target: "http://jsonplaceholder.typicode.com/",
 	pathRewrite: {
-		'^/api': ''
+		"^/api": ""
 	}
 };
 /**/

examples/proxy-hot-reload/webpack.config.js

@@ -1,21 +1,21 @@
-var fs = require('fs');
+var fs = require("fs");
 
-var proxyConfig = require('./proxy-config');
+var proxyConfig = require("./proxy-config");
 var proxyOptions = {
-	context: '/api',
+	context: "/api",
 	target: proxyConfig.target,
 	pathRewrite: proxyConfig.pathRewrite,
 	changeOrigin: true
 };
 
-fs.watch('./proxy-config.js', function() {
-	delete require.cache[require.resolve('./proxy-config')];
+fs.watch("./proxy-config.js", function() {
+	delete require.cache[require.resolve("./proxy-config")];
 	try {
-		var newProxyConfig = require('./proxy-config');
+		var newProxyConfig = require("./proxy-config");
 		if(proxyOptions.target !== newProxyConfig.target) {
-			console.log('Proxy target changed:', newProxyConfig.target);
+			console.log("Proxy target changed:", newProxyConfig.target);
 			proxyOptions = {
-				context: '/api',
+				context: "/api",
 				target: newProxyConfig.target,
 				pathRewrite: newProxyConfig.pathRewrite,
 				changeOrigin: true