revert: header check

Author: alexander-akait

lib/Server.js

@@ -1961,7 +1961,7 @@ class Server {
           (req.headers);
         const headerName = headers[":authority"] ? ":authority" : "host";
 
-        if (this.checkHeader(headers, headerName, true)) {
+        if (this.checkHeader(headers, headerName)) {
           next();
           return;
         }
@@ -2668,8 +2668,8 @@ class Server {
 
         if (
           !headers ||
-          !this.checkHeader(headers, "host", true) ||
-          !this.checkHeader(headers, "origin", false)
+          !this.checkHeader(headers, "host") ||
+          !this.checkHeader(headers, "origin")
         ) {
           this.sendMessage([client], "error", "Invalid Host/Origin header");
 
@@ -2703,7 +2703,8 @@ class Server {
 
         if (
           this.options.client &&
-          /** @type {ClientConfiguration} */ (this.options.client).reconnect
+          /** @type {ClientConfiguration} */
+          (this.options.client).reconnect
         ) {
           this.sendMessage(
             [client],
@@ -2718,9 +2719,9 @@ class Server {
           /** @type {ClientConfiguration} */
           (this.options.client).overlay
         ) {
-          const overlayConfig = /** @type {ClientConfiguration} */ (
-            this.options.client
-          ).overlay;
+          const overlayConfig =
+            /** @type {ClientConfiguration} */
+            (this.options.client).overlay;
 
           this.sendMessage(
             [client],
@@ -3108,10 +3109,9 @@ class Server {
    * @private
    * @param {{ [key: string]: string | undefined }} headers
    * @param {string} headerToCheck
-   * @param {boolean} allowIP
    * @returns {boolean}
    */
-  checkHeader(headers, headerToCheck, allowIP) {
+  checkHeader(headers, headerToCheck) {
     // allow user to opt out of this security check, at their own risk
     // by explicitly enabling allowedHosts
     if (this.options.allowedHosts === "all") {
@@ -3151,8 +3151,7 @@ class Server {
     // and its subdomains (hostname.endsWith(".localhost")).
     // allow hostname of listening address  (hostname === this.options.host)
     const isValidHostname =
-      (allowIP &&
-        hostname !== null &&
+      (hostname !== null &&
         (ipaddr.IPv4.isValid(hostname) || ipaddr.IPv6.isValid(hostname))) ||
       hostname === "localhost" ||
       (hostname !== null && hostname.endsWith(".localhost")) ||

types/lib/Server.d.ts

@@ -1351,7 +1351,6 @@ declare class Server<
    * @private
    * @param {{ [key: string]: string | undefined }} headers
    * @param {string} headerToCheck
-   * @param {boolean} allowIP
    * @returns {boolean}
    */
   private checkHeader;