ci: refactor types job (#4318)

Author: snitin315

.github/workflows/nodejs.yml

@@ -43,8 +43,11 @@ jobs:
       - name: Lint
         run: npm run lint
 
+      - name: Build types
+        run: npm run build:types
+
       - name: Check types
-        run: npm run check:types
+        run: if [ -n "$(git status types --porcelain)" ]; then echo "Missing types. Update types by running 'npm run build:types'"; exit 1; else echo "All types are valid"; fi
 
       - name: Security audit
         run: npm audit --production

package.json

@@ -26,7 +26,6 @@
     "build:client": "rimraf ./client/* && babel client-src/ --out-dir client/ --ignore \"client-src/webpack.config.js\" --ignore \"client-src/modules\" && webpack --config client-src/webpack.config.js",
     "build:types": "rimraf ./types/* && tsc --declaration --emitDeclarationOnly --outDir types && node ./scripts/extend-webpack-types.js && prettier \"types/**/*.ts\" --write && prettier \"types/**/*.ts\" --write",
     "build": "npm-run-all -p \"build:**\"",
-    "check:types": "node ./scripts/check-types.js",
     "test:only": "jest",
     "test:coverage": "npm run test:only -- --coverage",
     "test:watch": "npm run test:coverage --watch",