Skip to content

Commit b38755b

Browse files
committed
Merge branch 'radotzki-https-server-parameters'
2 parents a94ed30 + 05a45aa commit b38755b

File tree

1 file changed

+19
-8
lines changed

1 file changed

+19
-8
lines changed

lib/Server.js

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -240,14 +240,25 @@ function Server(compiler, options) {
240240
features[feature]();
241241
}, this);
242242

243-
this.listeningApp = options.https
244-
? https.createServer({
245-
// using built-in self-signed certificate
246-
key: options.key || fs.readFileSync(path.join(__dirname, "../ssl/server.key")),
247-
cert: options.cert || fs.readFileSync(path.join(__dirname, "../ssl/server.crt")),
248-
ca: options.ca || fs.readFileSync(path.join(__dirname, "../ssl/ca.crt"))
249-
}, app)
250-
: http.createServer(app);
243+
if (options.https) {
244+
// for keep supporting CLI parameters
245+
if (typeof options.https === 'boolean') {
246+
options.https = {
247+
key: options.key,
248+
cert: options.cert,
249+
ca: options.ca
250+
};
251+
}
252+
253+
// using built-in self-signed certificate if no certificate was configured
254+
options.https.key = options.https.key || fs.readFileSync(path.join(__dirname, "../ssl/server.key"));
255+
options.https.cert = options.https.cert || fs.readFileSync(path.join(__dirname, "../ssl/server.crt"));
256+
options.https.ca = options.https.ca || fs.readFileSync(path.join(__dirname, "../ssl/ca.crt"));
257+
258+
this.listeningApp = https.createServer(options.https, app);
259+
} else {
260+
this.listeningApp = http.createServer(app);
261+
}
251262
}
252263

253264
Server.prototype.use = function() {

0 commit comments

Comments
 (0)