Fixes #1805: Allow symlinks for devServer.https options (#1807)

Author: chaos-git

lib/Server.js

@@ -603,7 +603,7 @@ class Server {
           let stats = null;
 
           try {
-            stats = fs.lstatSync(value).isFile();
+            stats = fs.lstatSync(fs.realpathSync(value)).isFile();
           } catch (error) {
             // ignore error
           }

test/Https.test.js

@@ -5,6 +5,8 @@ const fs = require('fs');
 const request = require('supertest');
 const helper = require('./helper');
 const config = require('./fixtures/contentbase-config/webpack.config');
+const skipTestOnWindows = require('./helpers/conditional-test')
+  .skipTestOnWindows;
 
 const httpsCertificateDirectory = path.join(
   __dirname,
@@ -95,6 +97,36 @@ describe('HTTPS', () => {
     });
   });
 
+  describe('ca, pfx, key and cert are symlinks', () => {
+    if (skipTestOnWindows('Symlinks are not supported on Windows')) {
+      return;
+    }
+
+    beforeAll((done) => {
+      server = helper.start(
+        config,
+        {
+          contentBase: contentBasePublic,
+          https: {
+            ca: path.join(httpsCertificateDirectory, 'ca-symlink.pem'),
+            pfx: path.join(httpsCertificateDirectory, 'server-symlink.pfx'),
+            key: path.join(httpsCertificateDirectory, 'server-symlink.key'),
+            cert: path.join(httpsCertificateDirectory, 'server-symlink.crt'),
+            passphrase: 'webpack-dev-server',
+          },
+        },
+        done
+      );
+      req = request(server.app);
+    });
+
+    it('Request to index', (done) => {
+      req.get('/').expect(200, /Heyo/, done);
+    });
+
+    afterAll(helper.close);
+  });
+
   describe('ca, pfx, key and cert are raw strings', () => {
     beforeAll((done) => {
       server = helper.start(

test/fixtures/https-certificate/ca-symlink.pem

@@ -0,0 +1 @@
+ca.pem

test/fixtures/https-certificate/server-symlink.crt

@@ -0,0 +1 @@
+server.crt

test/fixtures/https-certificate/server-symlink.key

@@ -0,0 +1 @@
+server.key

test/fixtures/https-certificate/server-symlink.pfx

@@ -0,0 +1 @@
+server.pfx

test/helpers/conditional-test.js

@@ -0,0 +1,12 @@
+'use strict';
+
+const isWindows = process.platform === 'win32';
+
+function skipTestOnWindows(reason) {
+  if (isWindows) {
+    test.skip(reason, () => {});
+  }
+  return isWindows;
+}
+
+module.exports.skipTestOnWindows = skipTestOnWindows;