test: refactor progress tests to cleanup properly (#4916)

Author: snitin315

test/e2e/progress.test.js

@@ -28,50 +28,61 @@ describe("progress", () => {
 
     await server.start();
 
-    const { page, browser } = await runBrowser();
-
-    const consoleMessages = [];
-
-    let doHotUpdate = false;
-
-    page
-      .on("console", (message) => {
-        consoleMessages.push(message);
-      })
-      .on("request", (requestObj) => {
-        if (/\.hot-update\.(json|js)$/.test(requestObj.url())) {
-          doHotUpdate = true;
-        }
-      });
-
-    await page.goto(`http://localhost:${port}/`, {
-      waitUntil: "networkidle0",
-    });
-
-    fs.writeFileSync(cssFilePath, "body { background-color: rgb(255, 0, 0); }");
-
-    await new Promise((resolve) => {
-      const timer = setInterval(() => {
-        if (doHotUpdate) {
-          clearInterval(timer);
-
-          resolve();
-        }
-      }, 100);
-    });
-
-    await browser.close();
-
-    const progressConsoleMessage = consoleMessages.filter((message) =>
-      /^\[webpack-dev-server\] (\[[a-zA-Z]+\] )?[0-9]{1,3}% - /.test(
-        message.text()
-      )
-    );
-
-    expect(progressConsoleMessage.length > 0).toBe(true);
-
-    fs.unlinkSync(cssFilePath);
-
-    await server.stop();
+    try {
+      const { page, browser } = await runBrowser();
+
+      const consoleMessages = [];
+
+      try {
+        let doHotUpdate = false;
+
+        page
+          .on("console", (message) => {
+            consoleMessages.push(message);
+          })
+          .on("request", (requestObj) => {
+            if (/\.hot-update\.(json|js)$/.test(requestObj.url())) {
+              doHotUpdate = true;
+            }
+          });
+
+        await page.goto(`http://localhost:${port}/`, {
+          waitUntil: "networkidle0",
+        });
+
+        fs.writeFileSync(
+          cssFilePath,
+          "body { background-color: rgb(255, 0, 0); }"
+        );
+
+        await new Promise((resolve) => {
+          const timer = setInterval(() => {
+            if (doHotUpdate) {
+              clearInterval(timer);
+
+              resolve();
+            }
+          }, 100);
+        });
+      } catch (error) {
+        throw error;
+      } finally {
+        await browser.close();
+      }
+
+      const progressConsoleMessage = consoleMessages.filter((message) =>
+        /^\[webpack-dev-server\] (\[[a-zA-Z]+\] )?[0-9]{1,3}% - /.test(
+          message.text()
+        )
+      );
+
+      expect(progressConsoleMessage.length > 0).toBe(true);
+    } catch (error) {
+      throw error;
+    } finally {
+      fs.unlinkSync(cssFilePath);
+
+      await server.stop();
+    }
   });
 });