feat: remove SockJS support #5626
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #5626 +/- ##
==========================================
+ Coverage 83.56% 83.72% +0.16%
==========================================
Files 13 11 -2
Lines 2050 1966 -84
Branches 755 735 -20
==========================================
- Hits 1713 1646 -67
+ Misses 303 287 -16
+ Partials 34 33 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjohansebas
force-pushed
the
sockjs-remove
branch
from
7fb1abf to
e9d63b4
Compare
Signed-off-by: Sebastian Beltran <[email protected]>
…nd package-lock.json
bjohansebas
force-pushed
the
sockjs-remove
branch
from
012357a to
a181f84
Compare
Member
|
@bjohansebas If you will need a help feel free to ping me |
bjohansebas
force-pushed
the
sockjs-remove
branch
from
fc88df5 to
258907d
Compare
bjohansebas
changed the title
bjohansebas
force-pushed
the
sockjs-remove
branch
from
2b2d4d9 to
847d2ed
Compare
Member
Author
|
I don’t understand why macOS and Windows are failing. |
Member
|
@bjohansebas Looks like racing in tests... macos works fine, windows doesn't, do I need to look deeply? |
Member
Author
yes, please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes SockJS, which was used to maintain compatibility with older browsers, but is no longer necessary
What kind of change does this PR introduce?
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
yes
If relevant, what needs to be documented once your changes are merged or what have you already documented?