Skip to content

Commit 19ef422

Browse files
skipjackSpaceK33z
authored andcommitted
Branding Page (#303)
* Replacing the old cube png with all svg assets from webpack/media * Updating the config to load svgs more easily * Updating the footer and logo to use the new svgs * Adding a branding page * Adding a branding link to the footer * Moving hr from Page to Contributors
1 parent d2caca9 commit 19ef422

File tree

12 files changed

+152
-9
lines changed

12 files changed

+152
-9
lines changed

assets/cube.png

-22 KB
Binary file not shown.

assets/icon-square-big.svg

Lines changed: 29 additions & 0 deletions
Loading

assets/icon-square-small.svg

Lines changed: 28 additions & 0 deletions
Loading

assets/logo-on-dark-bg.svg

Lines changed: 27 additions & 0 deletions
Loading

assets/logo-on-white-bg.svg

Lines changed: 27 additions & 0 deletions
Loading

components/contributors/contributors.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export default ({contributors}) => {
88

99
return (
1010
<div className="contributors">
11+
<hr />
1112
<h3>Contributors:</h3>
1213
<div className="contributors__list">
1314
{

components/footer/footer-style.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,10 @@
5959
display:block;
6060
height:35px;
6161

62-
img { height:100%; width:auto; }
62+
img {
63+
width:auto;
64+
height:100%;
65+
}
6366
}
6467

6568
.footer__link {

components/footer/footer.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React from 'react';
22
import Link from '../link/link';
33
import Container from '../container/container';
4-
import CubeImg from '../../assets/cube.png';
4+
import Icon from '../../assets/icon-square-small.svg';
55
import './footer-style';
66

77
export default (props) => {
@@ -17,11 +17,12 @@ export default (props) => {
1717

1818
<section className="footer__middle">
1919
<Link to="/" className="footer__icon">
20-
<img src={ CubeImg } />
20+
<img src={ Icon } />
2121
</Link>
2222
</section>
2323

2424
<section className="footer__right">
25+
<Link className="footer__link" to="/branding">Branding</Link>
2526
<Link className="footer__link" to="//gitter.im/webpack/webpack">Support</Link>
2627
<Link className="footer__link" to="https://github.com/webpack/webpack/releases">Changelog</Link>
2728
<Link className="footer__link" to="/license">License</Link>

components/logo/logo.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import React from 'react';
2-
import CubeImg from '../../assets/cube.png';
2+
import Icon from '../../assets/icon-square-small.svg';
33
import './logo-style';
44

55
export default props => {
66
let { light } = props;
77

88
return (
9-
<span className={ `logo${light ? ' logo--light' : ''}` }>
10-
<img className="logo__icon" src={ CubeImg } />
9+
<span className={ `logo ${light ? 'logo--light' : ''}` }>
10+
<img className="logo__icon" src={ Icon } />
1111
<span className="logo__text">webpack</span>
1212
</span>
1313
);

components/page/page.jsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ export default ({ section, page }) => {
3333

3434
<div dangerouslySetInnerHTML={{ __html: page.content }} />
3535

36-
<hr />
37-
3836
<Contributors contributors={ page.contributors } />
3937
</section>
4038
</Container>

0 commit comments

Comments
 (0)