docs(plugins): use .includes over .indexOf

baldurh · skipjack · commit 1b5cf43832b3 · 2017-12-19T22:29:50.000-05:00
Consistent usage of `.includes`
diff --git a/src/content/plugins/commons-chunk-plugin.md b/src/content/plugins/commons-chunk-plugin.md
@@ -217,7 +217,7 @@ new webpack.optimize.CommonsChunkPlugin({
     if(module.resource && (/^.*\.(css|scss)$/).test(module.resource)) {
       return false;
     }
-    return module.context && module.context.indexOf("node_modules") !== -1;
+    return module.context && module.context.includes("node_modules");
   }
 })
 ```
@@ -242,7 +242,7 @@ Since the `vendor` and `manifest` chunk use a different definition for `minChunk
   new webpack.optimize.CommonsChunkPlugin({
     name: "vendor",
     minChunks: function(module){
-      return module.context && module.context.indexOf("node_modules") !== -1;
+      return module.context && module.context.includes("node_modules");
     }
   }),
   new webpack.optimize.CommonsChunkPlugin({

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ new webpack.optimize.CommonsChunkPlugin({`
`217`	`217`	`if(module.resource && (/^.*\.(css\|scss)$/).test(module.resource)) {`
`218`	`218`	`return false;`
`219`	`219`	`}`
`220`		`- return module.context && module.context.indexOf("node_modules") !== -1;`
	`220`	`+ return module.context && module.context.includes("node_modules");`
`221`	`221`	`}`
`222`	`222`	`})`
`223`	`223`	```
@@ -242,7 +242,7 @@ Since the `vendor` and `manifest` chunk use a different definition for `minChunk
`242`	`242`	`new webpack.optimize.CommonsChunkPlugin({`
`243`	`243`	`name: "vendor",`
`244`	`244`	`minChunks: function(module){`
`245`		`- return module.context && module.context.indexOf("node_modules") !== -1;`
	`245`	`+ return module.context && module.context.includes("node_modules");`
`246`	`246`	`}`
`247`	`247`	`}),`
`248`	`248`	`new webpack.optimize.CommonsChunkPlugin({`