Skip to content

Commit 80463ea

Browse files
committed
Refactoring Contributors and Page to prevent the need for a hack in Organization
1 parent a9388ea commit 80463ea

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

components/contributors/contributors.jsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ export default ({contributors}) => {
88

99
return (
1010
<div className="contributors">
11-
<hr />
12-
<h3>Contributors</h3>
1311
<div className="contributors__list">
1412
{
1513
contributors.map(contributor => (

components/organization/organization-style.scss

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,6 @@
2121
background:getColor(concrete);
2222
transition:all 250ms;
2323

24-
// TODO: Fix this, refactor Page and Contributors components
25-
.contributors h3,
26-
.contributors hr {
27-
display:none;
28-
}
29-
3024
&:hover {
3125
box-shadow:0 0 5px getColor(emperor);
3226
background:white;

components/page/page.jsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ export default ({ section, page }) => {
3636

3737
<div dangerouslySetInnerHTML={{ __html: page.content }} />
3838

39+
40+
<hr style={{ display: page.contributors.length ? 'block' : 'none' }} />
41+
<h3 style={{ display: page.contributors.length ? 'block' : 'none' }}>Contributors</h3>
3942
<Contributors contributors={ page.contributors } />
4043
</section>
4144
</Container>

0 commit comments

Comments
 (0)