Skip to content

Commit aa0ea1d

Browse files
authored
Merge pull request #436 from webpack/develop
Deploy
2 parents 3aab600 + 08bb677 commit aa0ea1d

File tree

11 files changed

+65
-43
lines changed

11 files changed

+65
-43
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ For more information see the [contributors page](https://github.com/webpack/webp
1818

1919
## Content Progress
2020

21-
Check out the [MVP Milestone](https://github.com/webpack/webpack.js.org/issues?q=is%3Aopen+is%3Aissue+milestone%3A%22Webpack+2+-+Documentation+MVP%22) for the current status.
21+
Check out the [MVP Milestone](https://github.com/webpack/webpack.js.org/milestones) for the current status.
Lines changed: 31 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,37 @@
1+
@import 'functions';
2+
3+
.contributors__list {
4+
padding: 6px;
5+
}
6+
17
.contributor {
2-
display: inline-block;
3-
margin-top:1em;
8+
display: inline-flex;
9+
flex-direction: column;
10+
align-items: center;
411
margin-right: 1em;
12+
font-size: 14px;
513

614
img {
7-
height: 50px;
15+
height: 45px;
16+
width: 45px;
17+
border-radius: 50%;
18+
box-shadow: 0 0 2px rgba(0,0,0,0.3);
19+
}
20+
21+
.contributor__name {
22+
color: getColor(fiord);
23+
margin-top: -6px;
24+
box-shadow: 0 0 2px rgba(0,0,0,0.3);
25+
line-height: 1.4;
26+
transition: color 0.1s;
27+
padding: 0 6px;
28+
border-radius: 2px;
29+
background: transparentize(getColor(white), 0.05);
30+
}
31+
32+
&:hover {
33+
.contributor__name {
34+
color: lighten(getColor(denim), 5%);
35+
}
836
}
937
}

components/contributors/contributors.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,15 @@ export default ({contributors}) => {
99
return (
1010
<div className="contributors">
1111
<hr />
12-
<h3>Contributors:</h3>
12+
<h3>Contributors</h3>
1313
<div className="contributors__list">
1414
{
1515
(contributors).map((contributor) => (
1616
<a key={ contributor }
1717
className="contributor"
1818
href={ `https://github.com/${contributor}` }>
19-
<img src={ `https://github.com/${contributor}.png?size=50` } />
19+
<img src={ `https://github.com/${contributor}.png?size=90` } />
20+
<span className="contributor__name"> {contributor}</span>
2021
</a>
2122
))
2223
}

components/splash/splash.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ export default props => {
2828
<p>Through contributions, donations, and sponsorship, you allow webpack to thrive. Your donations directly support office hours, continued enhancements, and most importantly, great documentation and learning material!</p>
2929

3030
<h2>Sponsors</h2>
31-
<Support number={ 5 } type="sponsor" />
31+
<Support number={ 20 } type="sponsor" />
3232

3333
<h2>Backers</h2>
34-
<Support number={ 20 } type="backer" />
34+
<Support number={ 100 } type="backer" />
3535
</Container>
3636
</div>
3737
);

components/support/support.jsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@ export default ({number, type}) => {
1414
alt={ `${type} avatar` } />
1515
</a>
1616
)}
17-
18-
<div className="support__bottom">
19-
<a className="support__button" href="https://opencollective.com/webpack#support">
20-
Become a { type.replace(/\b./g, m => m.toUpperCase()) }
21-
</a>
22-
</div>
2317
</div>
2418
);
2519
};

components/vote/influence.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ export default class InfluenceComponent extends React.Component {
55
constructor(props) {
66
super(props);
77
}
8-
8+
99
render() {
10-
return (this.props.type === "normal" ? (
10+
return (this.props.type === "normal" ? (
1111
<section className="influence-info influence-info__section">
1212
<h1 className="influence-info__header">What is Influence?</h1>
13-
<p><em>Influence</em> is a unit of measure based on time you have been a member on github. However, in 2017 and on you will recieve one influence per day.</p>
13+
<p><em>Influence</em> is a unit of measure based on time you have been a member on GitHub. However, in 2017 and on you will recieve one influence per day.</p>
1414
</section>
1515
) : (
1616
<section className="influence-info influence-info__section">
1717
<h1 className="influence-info__header">What is Golden Influence?</h1>
18-
<p><em>Golden Influence</em> is equal to 100 <i>normal influence</i>. Golden Influence is obtained by being a backer or sponsor on our <a href="https://opencollective.com/webpack">Open Collective page</a>.</p>
18+
<p><em>Golden Influence</em> is equal to 100 <i>normal influence</i>. Golden Influence is obtained by being a backer or sponsor on our <a href="https://opencollective.com/webpack">Open Collective page</a>.</p>
1919
</section>
2020
));
2121
}

content/configuration/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ contributors:
77
- grgur
88
---
99

10-
Webpack is fed a configuration object. It is passed in one of two ways depending on how you are using webpack: through the terminal or via Node.js. All the available configuration options are specified below.
10+
Webpack is fed via a configuration object. It is passed in one of two ways depending on how you are using webpack: through the terminal or via Node.js. All the available configuration options are specified below.
1111

1212
T> Notice that throughout the configuration we use Node's built-in [path module](https://nodejs.org/api/path.html). This prevents file path issues between operating systems. See [this section](https://nodejs.org/api/path.html#path_windows_vs_posix) for more.
1313

content/configuration/target.md

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,25 @@ contributors:
66
- sokra
77
- skipjack
88
- SpaceK33z
9+
- pastelsky
910
---
1011

11-
webpack can compile to multiple environments. We call this _targets_. This page shows what targets are supported. [The concept page](/concepts/targets) explains in greater detail what a target is.
12+
webpack can compile for multiple environments or _targets_. To understand what a target is in detail, read [the concepts](/concepts/targets).
1213

1314
## `target`
1415

1516
`string`
1617

17-
Tell webpack what environment the application is targeting. The following values are supported:
18+
Tells webpack which environment the application is targeting. The following values are supported:
1819

19-
* `"async-node"` Compile for usage in a Node.js-like environment (use `fs` and `vm` to load chunks async)
20-
* `"electron"` Compile for [Electron](http://electron.atom.io/) renderer process, provide a target using `JsonpTemplatePlugin`, `FunctionModulePlugin` for browser environment and `NodeTargetPlugin` and `ExternalsPlugin` for CommonJs and Electron built-in modules.
21-
* `"electron-renderer"` - Compile for [Electron](http://electron.atom.io/) for `renderer-process`
22-
* `"node"` Compile for usage in a Node.js-like environment (uses Node.js `require` to load chunks)
23-
* `"node-webkit"` Compile for usage in WebKit and uses jsonp chunk loading. Allows importing of built-in Node.js modules and [`nw.gui`](http://docs.nwjs.io/en/latest/) (experimental)
24-
* `"web"` Compile for usage in a browser-like environment (default)
25-
* `"webworker"` Compile as WebWorker
20+
| `target` | Description |
21+
| ------------- |------------------------|
22+
| `async-node`| Compile for usage in a Node.js-like environment (uses `fs` and `vm` to load chunks asynchronously) |
23+
| `electron` | Compile for [Electron](http://electron.atom.io/) renderer process, provide a target using `JsonpTemplatePlugin`, `FunctionModulePlugin` for browser environments and `NodeTargetPlugin` and `ExternalsPlugin` for CommonJs and Electron built-in modules. |
24+
| `electron-renderer` | Compile for [Electron](http://electron.atom.io/) for `renderer-process` |
25+
| `"node"` | Compile for usage in a Node.js-like environment (uses Node.js `require` to load chunks) |
26+
|`node-webkit`| Compile for usage in WebKit and uses JSONP for chunk loading. Allows importing of built-in Node.js modules and [`nw.gui`](http://docs.nwjs.io/en/latest/) (experimental) |
27+
|`web`| Compile for usage in a browser-like environment **(default)** |
28+
|`webworker`| Compile as WebWorker |
2629

27-
For example, when you use the `"electron"` _target_, *webpack* includes multiple Electron specific variables. For more information on which templates and _externals_ are used, you can refer [directly to the webpack source code](https://github.com/webpack/webpack/blob/master/lib/WebpackOptionsApply.js#L70-L185).
28-
29-
The target option defaults to:
30-
31-
```js
32-
target: "web"
33-
```
30+
For example, when the `target` is set to `"electron"`, webpack includes multiple electron specific variables. For more information on which templates and externals are used, you can refer to webpack's [source code](https://github.com/webpack/webpack/blob/master/lib/WebpackOptionsApply.js#L70-L185).

content/get-started/index.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,9 @@ Also we will need to change the `index.html` to expect a single bundled js file.
8585
<title>Webpack demo</title>
8686
- <script src="https://unpkg.com/[email protected]" type="text/javascript"></script>
8787
- <script src="app/index.js" type="text/javascript"></script>
88-
+ <script src="dist/bundle.js" type="text/javascript"></script>
8988
</head>
9089
<body>
91-
<div id="root"></div>
90+
+ <script src="dist/bundle.js" type="text/javascript"></script>
9291
</body>
9392
</html>
9493
```

content/guides/code-splitting-libraries.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ __webpack.config.js__
3333

3434
```javascript
3535

36-
modules.export = function(env) {
36+
module.exports = function(env) {
3737
return {
3838
entry: './index.js',
3939
output: {
@@ -56,7 +56,7 @@ __webpack.config.js__
5656
5757
```javascript
5858
59-
modules.export = function(env) {
59+
module.exports = function(env) {
6060
return {
6161
entry: {
6262
main: './index.js',
@@ -85,7 +85,7 @@ __webpack.config.js__
8585
```javascript
8686
8787
var webpack = require('webpack');
88-
modules.export = function(env) {
88+
module.exports = function(env) {
8989
return {
9090
entry: {
9191
main: './index.js',
@@ -119,7 +119,7 @@ __webpack.config.js__
119119
```javascript
120120

121121
var webpack = require('webpack');
122-
modules.export = function(env) {
122+
module.exports = function(env) {
123123
return {
124124
entry: {
125125
main: './index.js',
@@ -138,4 +138,4 @@ modules.export = function(env) {
138138
};
139139
```
140140

141-
With the above webpack config, we see three bundles being generated. `vendor`, `main` and `manifest` bundles.
141+
With the above webpack config, we see three bundles being generated. `vendor`, `main` and `manifest` bundles.

0 commit comments

Comments
 (0)