Skip to content

Commit df88414

Browse files
kevinzwhuangSpaceK33z
authored andcommitted
Grammar improvements in upgrade-from-webpack-1.md
Summary: ---- Was going through a migration from v1 to v2 and saw a few things that could be improved in the migration docs. Hope this helps.
1 parent 46161d8 commit df88414

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

content/how-to/upgrade-from-webpack-1.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ More stuff was changed here. Not listed in detail as it's not commonly used. See
3030

3131
## `module.loaders` is now `module.rules`
3232

33-
The old loader configuration was superseded by a more powerful rules system, which allows to configure loaders and more.
34-
For compatibility reasons the old syntax is still valid and the old names are parsed.
35-
The new naming is easier to understand to there are good reasons to upgrade the configuration.
33+
The old loader configuration was superseded by a more powerful rules system, which allows configuration of loaders and more.
34+
For compatibility reasons, the old `module.loaders` syntax is still valid and the old names are parsed.
35+
The new naming conventions are easier to understand and are a good reason to upgrade the configuration to using `module.rules`.
3636

3737
``` diff
3838
module: {
@@ -92,7 +92,7 @@ See [#2986](https://github.com/webpack/webpack/issues/2986) for the reason behin
9292
## `UglifyJsPlugin` sourceMap
9393

9494
The `sourceMap` option of the `UglifyJsPlugin` now defaults to `false` instead of `true`.
95-
This means if using SourceMaps for the minimized code you need to pass `sourceMap: true`.
95+
This means that if you are using source maps for minimized code, you need to set `sourceMap: true` for `UglifyJsPlugin`.
9696

9797
``` diff
9898
devtool: "source-map",
@@ -105,7 +105,7 @@ This means if using SourceMaps for the minimized code you need to pass `sourceMa
105105

106106
## `UglifyJsPlugin` minimize loaders
107107

108-
The UglifyJsPlugin does not longer switch loaders into minimize mode. This need to be passed via loader options in long-term. See loader documentation for relevant options.
108+
`UglifyJsPlugin` no longer switches loaders into minimize mode. The `minimize: true` setting needs to be passed via loader options in long-term. See loader documentation for relevant options.
109109

110110
The minimize mode for loaders will be removed in webpack 3 or later.
111111

0 commit comments

Comments
 (0)