bug fixes and more friendly touch responses

prateekbh · skipjack · commit ee04ff103cc0 · 2016-11-20T22:29:29.000-05:00
diff --git a/components/sidebar-mobile/sidebar-mobile-style.scss b/components/sidebar-mobile/sidebar-mobile-style.scss
@@ -28,9 +28,9 @@
 
   .opener{
     position: absolute;
-    top: 0;
+    top: 45px;
     bottom: 0;
-    width: 10px;
+    width: 32px;
     left: 285px;
   }
 
diff --git a/components/sidebar-mobile/sidebar-mobile.jsx b/components/sidebar-mobile/sidebar-mobile.jsx
@@ -123,7 +123,7 @@ export default class SidebarMobile extends React.Component {
 
   _handleTouchStart(e){
     initialTouchPosition.x = e.touches[0].pageX;
-    initialTouchPosition.y = e.touches[0].clientY;
+    initialTouchPosition.y = e.touches[0].pageY;
     //for instant transform along with the touch
     this.container.classList.add("no-delay");
   }
@@ -137,7 +137,7 @@ export default class SidebarMobile extends React.Component {
       e.preventDefault();
       this.container.style.transform="translateX(-"+xDiff+"px)";
       lastTouchPosition.x = e.touches[0].pageX;
-      lastTouchPosition.y = e.touches[0].clientY;
+      lastTouchPosition.y = e.touches[0].pageY;
     }
   }
 
@@ -150,7 +150,7 @@ export default class SidebarMobile extends React.Component {
       e.preventDefault();
       this.container.style.transform="translateX(calc(-100% + "+xDiff+"px))";
       lastTouchPosition.x = e.touches[0].pageX;
-      lastTouchPosition.y = e.touches[0].clientY;
+      lastTouchPosition.y = e.touches[0].pageY;
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ export default class SidebarMobile extends React.Component {`
`123`	`123`
`124`	`124`	`_handleTouchStart(e){`
`125`	`125`	`initialTouchPosition.x = e.touches[0].pageX;`
`126`		`- initialTouchPosition.y = e.touches[0].clientY;`
	`126`	`+ initialTouchPosition.y = e.touches[0].pageY;`
`127`	`127`	`//for instant transform along with the touch`
`128`	`128`	`this.container.classList.add("no-delay");`
`129`	`129`	`}`
`@@ -137,7 +137,7 @@ export default class SidebarMobile extends React.Component {`
`137`	`137`	`e.preventDefault();`
`138`	`138`	`this.container.style.transform="translateX(-"+xDiff+"px)";`
`139`	`139`	`lastTouchPosition.x = e.touches[0].pageX;`
`140`		`- lastTouchPosition.y = e.touches[0].clientY;`
	`140`	`+ lastTouchPosition.y = e.touches[0].pageY;`
`141`	`141`	`}`
`142`	`142`	`}`
`143`	`143`
`@@ -150,7 +150,7 @@ export default class SidebarMobile extends React.Component {`
`150`	`150`	`e.preventDefault();`
`151`	`151`	`this.container.style.transform="translateX(calc(-100% + "+xDiff+"px))";`
`152`	`152`	`lastTouchPosition.x = e.touches[0].pageX;`
`153`		`- lastTouchPosition.y = e.touches[0].clientY;`
	`153`	`+ lastTouchPosition.y = e.touches[0].pageY;`
`154`	`154`	`}`
`155`	`155`	`}`
`156`	`156`