Refactors Management Hub configuration

Consolidates Management Hub configuration settings into the ServiceConfig class for better organization and access.

Removes the `IsManagementHubService` property from `CoreAppSettings` and replaces it with `IsManagementHub` in `ServiceConfig`.

Ensures that the Management Hub functionality is consistently enabled based on the new configuration properties.

Improves error messaging for Management Hub joining authentication failures, clarifying potential causes.

Author: webprofusion-chrisc

src/Certify.Core/Management/CertifyManager/CertifyManager.Maintenance.cs

@@ -26,7 +26,7 @@ private async Task UpgradeSettings()
 
             if (
                 Environment.GetEnvironmentVariable("CERTIFY_ENABLE_MANAGEMENT_HUB")?.Equals("true", StringComparison.InvariantCultureIgnoreCase) == true
-                || CoreAppSettings.Current.IsManagementHubService
+                || _serverConfig.IsManagementHub
                 || _isDirectMgmtHubBackend
                 )
             {
@@ -47,15 +47,10 @@ private async Task UpgradeSettings()
                 // update the system version
                 CoreAppSettings.Current.CurrentServiceVersion = systemVersion;
 
-                if (_isMgtmHubBackend)
-                {
-                    CoreAppSettings.Current.IsManagementHubService = true;
-                }
-
                 SettingsManager.SaveAppSettings();
 
                 // if we are a management hub backend, register with the hub if not already registered
-                if (CoreAppSettings.Current.IsManagementHubService)
+                if (_isMgtmHubBackend)
                 {
                     var accessControl = await GetCurrentAccessControl();
                     await AccessControlConfig.ConfigureStandardUsersAndRoles(accessControl, _credentialsManager);

src/Certify.Core/Management/CertifyManager/CertifyManager.ManagementHub.cs

@@ -126,17 +126,16 @@ await _credentialsManager.Update(new StoredCredential
         /// <returns>Returns an action result indicating the success of the connection attempt and any relevant hub information.</returns>
         public async Task<ActionResult<HubJoiningInfo>> CheckManagementHubCredentials(string url, ClientSecret clientSecret, bool registerInstance = false)
         {
-            var hubAssignedInstanceId = _serverConfig.HubAssignedInstanceId;
 
             using (var httpClient = new System.Net.Http.HttpClient())
             {
                 var request = new System.Net.Http.HttpRequestMessage(System.Net.Http.HttpMethod.Get, $"{url.TrimEnd('/')}/api/v1/hub/{(registerInstance ? "register" : "joincheck")}");
                 request.Headers.Add("X-Client-ID", clientSecret.ClientId);
                 request.Headers.Add("X-Client-Secret", clientSecret.Secret);
 
-                if (!string.IsNullOrEmpty(hubAssignedInstanceId))
+                if (!string.IsNullOrEmpty(_serverConfig.HubAssignedInstanceId))
                 {
-                    request.Headers.Add("X-Certify-HubAssignedId", hubAssignedInstanceId);
+                    request.Headers.Add("X-Certify-HubAssignedId", _serverConfig.HubAssignedInstanceId);
                 }
 
                 try
@@ -318,6 +317,7 @@ private async Task EnsureMgmtHubConnection()
 
                             // acquire new token
                             var check = await CheckManagementHubCredentials(api, _mgmtHubJoiningSecret);
+
                             if (check.IsSuccess)
                             {
                                 if (_serverConfig.HubAssignedInstanceId != check.Result.HubAssignedInstanceId)
@@ -351,7 +351,7 @@ private async Task EnsureMgmtHubConnection()
                                     SystemStatusCategories.SERVICE_CORE,
                                     SystemStatusKeys.SERVICE_CORE_HUB_JOINING_AUTH,
                                     "Management Hub Joining Auth",
-                                    "Management hub joining auth failed, instance cannot join hub. Joining key may be invalid or for a different hub.",
+                                    "Management hub joining auth failed, instance cannot join hub. Joining key (or current Hub Assigned ID) may be invalid or for a different hub.",
                                     hasError: true
                                 );
 

src/Certify.Core/Management/SettingsManager.cs

@@ -185,11 +185,6 @@ public static CoreAppSettings Current
         /// If true, ARI checks will not be performed during periodic maintenance
         /// </summary>
         public bool DisableARIChecks { get; set; }
-
-        /// <summary>
-        ///  if true, additional management hub features and data stores may be enabled
-        /// </summary>
-        public bool IsManagementHubService { get; set; }
     }
 
     public class SettingsManager

src/Certify.Models/Shared/ServiceConfig.cs

@@ -37,6 +37,7 @@ public class ServiceConfig
         public string ManagementServerHubAPI { get; set; } = string.Empty;
         public string ManagementServerHubEndpoint { get; set; } = string.Empty;
         public string HubAssignedInstanceId { get; set; } = string.Empty;
+        public bool IsManagementHub { get; set; }
     }
 
     public enum ConfigStatus