Refactor for nullable record struct

webprofusion-chrisc · webprofusion-chrisc · commit 4aeb4f47ee76 · 2025-05-02T16:08:04.000+08:00
diff --git a/src/Certify.Server/Certify.Server.Hub.Api/SignalR/ManagementHub/InstanceManagementStateProvider.cs b/src/Certify.Server/Certify.Server.Hub.Api/SignalR/ManagementHub/InstanceManagementStateProvider.cs
@@ -313,11 +313,13 @@ public ConcurrentDictionary<string, StatusSummary> GetManagedInstanceStatusSumma
         /// <param name="managedCertificate"></param>
         public void UpdateCachedManagedInstanceItem(string instanceId, ManagedCertificate managedCertificate)
         {
-            _managedInstanceItems.TryGetValue(instanceId, out var instance);
-            if (instance?.Items != null)
+            if (_managedInstanceItems.TryGetValue(instanceId, out var instance))
             {
-                instance.Items.RemoveAll(r => r.Id == managedCertificate.Id);
-                instance.Items.Add(managedCertificate);
+                if (instance.Items != null)
+                {
+                    instance.Items.RemoveAll(r => r.Id == managedCertificate.Id);
+                    instance.Items.Add(managedCertificate);
+                }
             }
         }
 
@@ -348,9 +350,7 @@ public bool HasStatusSummaryForManagedInstance(string instanceId)
         /// <param name="managedCertificateId"></param>
         public void DeleteCachedManagedInstanceItem(string instanceId, string managedCertificateId)
         {
-            _managedInstanceItems.TryGetValue(instanceId, out var instance);
-
-            if (instance?.Items != null)
+            if (_managedInstanceItems.TryGetValue(instanceId, out var instance))
             {
                 instance.Items.RemoveAll(r => r.Id == managedCertificateId);
             }

Original file line number	Diff line number	Diff line change
`@@ -313,11 +313,13 @@ public ConcurrentDictionary<string, StatusSummary> GetManagedInstanceStatusSumma`
`313`	`313`	`/// <param name="managedCertificate"></param>`
`314`	`314`	`public void UpdateCachedManagedInstanceItem(string instanceId, ManagedCertificate managedCertificate)`
`315`	`315`	`{`
`316`		`- _managedInstanceItems.TryGetValue(instanceId, out var instance);`
`317`		`- if (instance?.Items != null)`
	`316`	`+ if (_managedInstanceItems.TryGetValue(instanceId, out var instance))`
`318`	`317`	`{`
`319`		`- instance.Items.RemoveAll(r => r.Id == managedCertificate.Id);`
`320`		`- instance.Items.Add(managedCertificate);`
	`318`	`+ if (instance.Items != null)`
	`319`	`+ {`
	`320`	`+ instance.Items.RemoveAll(r => r.Id == managedCertificate.Id);`
	`321`	`+ instance.Items.Add(managedCertificate);`
	`322`	`+ }`
`321`	`323`	`}`
`322`	`324`	`}`
`323`	`325`
`@@ -348,9 +350,7 @@ public bool HasStatusSummaryForManagedInstance(string instanceId)`
`348`	`350`	`/// <param name="managedCertificateId"></param>`
`349`	`351`	`public void DeleteCachedManagedInstanceItem(string instanceId, string managedCertificateId)`
`350`	`352`	`{`
`351`		`- _managedInstanceItems.TryGetValue(instanceId, out var instance);`
`352`		`-`
`353`		`- if (instance?.Items != null)`
	`353`	`+ if (_managedInstanceItems.TryGetValue(instanceId, out var instance))`
`354`	`354`	`{`
`355`	`355`	`instance.Items.RemoveAll(r => r.Id == managedCertificateId);`
`356`	`356`	`}`