Update deployment tab description for clarity

Author: webprofusion-chrisc

src/Certify.Core/Management/PreviewManager.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
@@ -218,8 +218,6 @@ ICredentialsManager credentialsManager
                           $"{newLine}**This challenge type will be selected for all identifiers.**");
                         }
                     }
-
-                    challengeInfo.AppendLine($"{newLine}---{newLine}");
                 }
 
                 steps.Add(new ActionStep
@@ -281,51 +279,59 @@ ICredentialsManager credentialsManager
                 {
                     // deploying to single or multiple Site
 
-                    if (item.RequestConfig.DeploymentBindingMatchHostname)
+                    if (serverProvider == null)
                     {
-                        deploymentDescription.AppendLine(
-                            "* Deploy to hostname bindings matching certificate domains.");
+                        deploymentDescription.AppendLine($"* Target instance has no supported targets for auto-deployment (e.g. IIS). Deployment Tasks may still apply.");
                     }
-
-                    if (item.RequestConfig.DeploymentBindingBlankHostname)
+                    else
                     {
-                        deploymentDescription.AppendLine("* Deploy to bindings with blank hostname.");
-                    }
 
-                    if (item.RequestConfig.DeploymentBindingReplacePrevious)
-                    {
-                        deploymentDescription.AppendLine("* Deploy to bindings with previous certificate.");
-                    }
+                        if (item.RequestConfig.DeploymentBindingMatchHostname)
+                        {
+                            deploymentDescription.AppendLine(
+                                "* Deploy to hostname bindings matching certificate domains.");
+                        }
 
-                    if (item.RequestConfig.DeploymentBindingOption == DeploymentBindingOption.AddOrUpdate)
-                    {
-                        deploymentDescription.AppendLine("* Add or Update https bindings as required");
-                    }
+                        if (item.RequestConfig.DeploymentBindingBlankHostname)
+                        {
+                            deploymentDescription.AppendLine("* Deploy to bindings with blank hostname.");
+                        }
 
-                    if (item.RequestConfig.DeploymentBindingOption == DeploymentBindingOption.UpdateOnly)
-                    {
-                        deploymentDescription.AppendLine("* Update https bindings as required (no auto-created https bindings)");
-                    }
+                        if (item.RequestConfig.DeploymentBindingReplacePrevious)
+                        {
+                            deploymentDescription.AppendLine("* Deploy to bindings with previous certificate.");
+                        }
 
-                    if (item.RequestConfig.DeploymentSiteOption == DeploymentOption.SingleSite)
-                    {
-                        if (!string.IsNullOrEmpty(item.ServerSiteId))
+                        if (item.RequestConfig.DeploymentBindingOption == DeploymentBindingOption.AddOrUpdate)
                         {
-                            try
-                            {
-                                var siteInfo = await serverProvider.GetSiteById(item.ServerSiteId);
-                                deploymentDescription.AppendLine($"## Deploying to Site" + newLine + newLine +
-                                                         $"`{siteInfo.Name}`" + newLine);
-                            }
-                            catch (Exception exp)
+                            deploymentDescription.AppendLine("* Add or Update https bindings as required");
+                        }
+
+                        if (item.RequestConfig.DeploymentBindingOption == DeploymentBindingOption.UpdateOnly)
+                        {
+                            deploymentDescription.AppendLine("* Update https bindings as required (no auto-created https bindings)");
+                        }
+
+                        if (item.RequestConfig.DeploymentSiteOption == DeploymentOption.SingleSite)
+                        {
+                            if (!string.IsNullOrEmpty(item.ServerSiteId))
                             {
-                                deploymentDescription.AppendLine($"Error: **cannot identify selected site.** {exp.Message} ");
+                                try
+                                {
+                                    var siteInfo = await serverProvider.GetSiteById(item.ServerSiteId);
+                                    deploymentDescription.AppendLine($"## Deploying to Site" + newLine + newLine +
+                                                             $"`{siteInfo.Name}`" + newLine);
+                                }
+                                catch (Exception exp)
+                                {
+                                    deploymentDescription.AppendLine($"Error: **cannot identify selected site.** {exp.Message} ");
+                                }
                             }
                         }
-                    }
-                    else
-                    {
-                        deploymentDescription.AppendLine($"## Deploying to all matching sites:");
+                        else
+                        {
+                            deploymentDescription.AppendLine($"## Deploying to all matching sites:");
+                        }
                     }
 
                     // add deployment sub-steps (if any)
@@ -366,7 +372,7 @@ ICredentialsManager credentialsManager
                 }
                 else if (item.RequestConfig.DeploymentSiteOption == DeploymentOption.NoDeployment)
                 {
-                    deploymentDescription.AppendLine("* The certificate will be saved to local disk only.");
+                    deploymentDescription.AppendLine("* The certificate will be saved to local storage.");
                 }
 
                 deploymentStep.Description = deploymentDescription.ToString();

src/Certify.Locales/SR.Designer.cs

@@ -672,7 +672,7 @@
     <value>Stored credentials are required to make automated calls to APIs and other resources during certificate renewal and deployment. These credentials are protected using the Windows Data Protection APIs and stored on this machine.</value>
   </data>
   <data name="ManagedCertificates_Deployment_Intro" xml:space="preserve">
-    <value>  Deployment of your certificate can be automatic or you can perform your own deployment tasks (see the Tasks tab).</value>
+    <value>Deployment of your certificate can be automatic (if targeting IIS) or you can perform your own deployment tasks (see the Tasks tab).</value>
   </data>
   <data name="ManagedCertificates_Tasks_Intro" xml:space="preserve">
     <value>Tasks are an optional way to work with your latest certificate or trigger other actions before or after renewal. </value>