ensure redirects are followed for sitemap, robots, other requests converted from fetch() #955
+63
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verted from fetch() - add a redirect interceptor to getProxyDispatcher(), with option to disable - add getDefaultDispatcher() for defaulting to follow redirects - fixes #954
- getProxyDispatcher(withRedirect: boolean) used for all archival content fetching, ignores TLS errors (to match browser config), and can follow redirects - getFollowRedirectDispatcher() use for other fetches where following redirects is needed, but TLS certs should be verified (eg. behaviors files, profile loading)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor dispatcher apis:
getProxyDispatcher(withRedirect = true)to follow redirects by default, with option to disable (eg. in recorder). This dispatcher also ignores TLS errors, to match current browser config. Used for fetching archival content.getFollowRedirectsDispatcher()with follows redirects but does not ignore TLS and does not use proxies, for fetching non-archival configs (profiles, behaviors, etc...)Fixes #954, regression from #946
Testing:
docker run --rm webrecorder/browsertrix-crawler crawl --url https://eff.org/ --useSitemap --logging debug --context sitemap"Not loading sitemap: invalid status code","details":{"status":301}}