Skip to content

Commit 112bbfa

Browse files
authored
Fix bug preventing browser profiles and deduplication from being used together in crawls (#3234)
Fixes #3229 A bug was preventing browser profiles from being passed to the crawler args when dedupe was enabled. This PR fixes the conditional logic in the `crawler.yaml` template so that dedupe and profile can be used together for crawls, but neither can be used in QA.
1 parent c391356 commit 112bbfa

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

chart/app-templates/crawler.yaml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -137,16 +137,19 @@ spec:
137137
- "{{ workers }}"
138138
- --redisStoreUrl
139139
- {{ redis_url }}
140+
{% if qa_source_crawl_id %}
141+
- --qaSource
142+
- /tmp/qa/qa-config.json
143+
{% else %}
140144
{% if redis_dedupe_url %}
141145
- --redisDedupeUrl
142146
- {{ redis_dedupe_url }}
143-
{% elif qa_source_crawl_id %}
144-
- --qaSource
145-
- /tmp/qa/qa-config.json
146-
{% elif profile_filename %}
147+
{% endif %}
148+
{% if profile_filename %}
147149
- --profile
148150
- "@{{ profile_filename }}"
149-
{% if save_profile %}
151+
{% endif %}
152+
{% if profile_filename and save_profile %}
150153
- --saveProfile
151154
{% endif %}
152155
{% endif %}

0 commit comments

Comments
 (0)