Frontend browser profile UI enhancements origin check fix (#3030)

- Fix for 'Create Profile' button sometimes not being enabled due to
event not firing, see:
#3024 (comment)
- Ensure that if origins are loaded before browser is ready, both are
checked separately.

Author: ikreymer

frontend/src/features/browser-profiles/profile-browser-dialog.ts

@@ -29,7 +29,6 @@ enum BrowserStatus {
   Initial,
   Pending,
   Ready,
-  Complete,
   Error,
 }
 
@@ -54,6 +53,9 @@ export class ProfileBrowserDialog extends BtrixElement {
   @state()
   private browserStatus = BrowserStatus.Initial;
 
+  @state()
+  private originsLoaded = false;
+
   @state()
   private showConfirmation = false;
 
@@ -151,7 +153,8 @@ export class ProfileBrowserDialog extends BtrixElement {
   render() {
     const isCrawler = this.appState.isCrawler;
     const creatingNew = this.duplicating || !this.profile;
-    const incomplete = this.browserStatus !== BrowserStatus.Complete;
+    const incomplete =
+      !this.originsLoaded || this.browserStatus !== BrowserStatus.Ready;
     const saving = this.saveProfileTask.status === TaskStatus.PENDING;
 
     return html`<btrix-dialog
@@ -341,7 +344,7 @@ export class ProfileBrowserDialog extends BtrixElement {
     e: CustomEvent<BrowserOriginsChange>,
   ) => {
     if (e.detail.origins.length) {
-      this.browserStatus = BrowserStatus.Complete;
+      this.originsLoaded = true;
     }
   };
 

frontend/src/features/browser-profiles/profile-browser.ts

@@ -173,11 +173,7 @@ export class ProfileBrowser extends BtrixElement {
       try {
         const { origins } = await this.pingBrowser(browser.id, signal);
 
-        if (
-          this.originsTask.value &&
-          origins &&
-          isNotEqual(this.originsTask.value, origins)
-        ) {
+        if (origins && isNotEqual(this.originsTask.value, origins)) {
           this.dispatchEvent(
             new CustomEvent<BrowserOriginsChange>(
               "btrix-browser-origins-change",