Skip to content

Commit 45e3c8a

Browse files
authored
Fix client-side replay error page + wabac.js update (#945)
* fixes for client-side replay - always serve top frame resource in client-side-replay mode, fixes #936 - deps: bump wabac.js to 2.23.8 for additional fixes * skip test that relies on ait
1 parent 8ea2f74 commit 45e3c8a

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

pywb/apps/rewriterapp.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ def render_content(self, wb_url, kwargs, environ):
386386
full_prefix, host_prefix,
387387
kwargs)
388388

389-
keep_frame_response = (not kwargs.get('no_timegate_check') and is_timegate and not is_proxy) or redirect_to_exact
389+
keep_frame_response = (not kwargs.get('no_timegate_check') and is_timegate and not is_proxy) or redirect_to_exact or self.client_side_replay
390390

391391

392392
if response and not keep_frame_response:

pywb/warcserver/index/test/test_indexsource.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,8 @@ def test_file_not_found(self):
186186
assert(errs['source'] == "NotFoundException('testdata/not-found-x',)"), errs
187187

188188
def test_ait_filters(self):
189+
pytest.skip("ait issue, may not work anymore")
190+
189191
ait_source = RemoteIndexSource('http://wayback.archive-it.org/cdx/search/cdx?url={url}&filter=filename:ARCHIVEIT-({colls})-.*',
190192
'http://wayback.archive-it.org/all/{timestamp}id_/{url}')
191193

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
root_dir = pathlib.Path(__file__).parent
1616

1717

18-
WABAC_SW_URL = "https://cdn.jsdelivr.net/npm/@webrecorder/wabac@2.22.15/dist/sw.js"
18+
WABAC_SW_URL = "https://cdn.jsdelivr.net/npm/@webrecorder/wabac@2.23.8/dist/sw.js"
1919

2020
def download_wabac_sw():
2121
print(f"Downloading {WABAC_SW_URL}")

0 commit comments

Comments
 (0)