Update test_html_rewriter to match Python HtmlParser's new behavior (#970)

ato · web-flow · commit 82e83afb62f3 · 2025-11-06T10:23:47.000-05:00
In Python 3.9.24, 3.10.19, 3.11.14, 3.12.12, 3.13.6 and 3.14.0 HtmlParser was changed as a security update to more correctly follow the HTML5 standard. This changed the output of one of our tests. The output change doesn't appear to have a meaningful impact in this case as browsers treat it as a comment either way, so this just updates the test to match the output of the latest Python versions. Fixes #969
diff --git a/pywb/rewrite/test/test_html_rewriter.py b/pywb/rewrite/test/test_html_rewriter.py
@@ -413,8 +413,10 @@
 <!--[if !IE]><html><![endif]--><a href="/web/20131226101010/http://example.com/"><!--[if IE]><![endif]--><a href="/web/20131226101010/http://example.com/"></html>
 
 # IE conditional with invalid ']-->' ending, rewritten as ']>'
+# Note: HtmlParser was changed in Python 3.9.24, 3.10.19, 3.11.14, 3.12.12, 3.13.6, 3.14.0.
+# The output of this test will differ on older Python versions.
 >>> parse('<!--[if !IE]> --><html><![endif]--><a href="http://example.com/"><!--[if IE]><![endif]--><a href="http://example.com/"></html>')
-<!--[if !IE]> --><html><![endif]><a href="/web/20131226101010/http://example.com/"><!--[if IE]><![endif]--><a href="/web/20131226101010/http://example.com/"></html>
+<!--[if !IE]> --><html><!--[endif]----><a href="/web/20131226101010/http://example.com/"><!--[if IE]><![endif]--><a href="/web/20131226101010/http://example.com/"></html>
 
 # Test tag with a target
 >>> parse('<HTML><A Href=\"page.html\" target=\"_blank\">Text</a></hTmL>')
